Skip to content

Fix: Can now force character independence regardless of current following status. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markscho wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix: Can now force character independence regardless of current following status. #54

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4333ad
Fix: Items with a previously-saved inventory (eg, containers) will no…
markscho Jan 26, 2019
7614f4b
Merge remote-tracking branch 'upstream/master'
markscho Jan 27, 2019
09bc9ad
Fix: Multiple instantaneously-queued spells/skills now show correct lag.
markscho Jan 30, 2019
f2760ec
Merge remote-tracking branch 'upstream/master'
markscho Feb 17, 2019
32c7ca0
Fix: can now force character independence regardless of current follo…
markscho Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Character.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,13 +500,15 @@ class Character extends Metadatable(EventEmitter) {
* @fires Character#unfollowed
*/
unfollow() {
this.following.removeFollower(this);
/**
* @event Character#unfollowed
* @param {Character} following
*/
this.emit('unfollowed', this.following);
this.following = null;
if (this.following) {
Copy link
Member

@shawncplus shawncplus Feb 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a proponent of early return. So instead of wrapping the entire function body in an if, you can instead just do

if (!this.following) {
  return
}

this.following.removeFollower(this);
/**
* @event Character#unfollowed
* @param {Character} following
*/
this.emit('unfollowed', this.following);
this.following = null;
}
}

/**
Expand Down