Conversation
WalkthroughUpdated EAS build configuration for the "internal" profile in eas.json by setting distribution to "internal" and changing APP_ENV from "development" to "internal". No code or API surface changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Approve |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
eas.json(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
eas.json (1)
54-54: LGTM on switching to internal distribution for the "internal" profileThis aligns with ad-hoc/enterprise-style installs. Please confirm:
- iOS: Apple credentials and tester device UDIDs (or enterprise cert) are set in EAS.
- Android: APK artifact is intended for sideloading (matches buildType: apk).
| }, | ||
| "env": { | ||
| "APP_ENV": "development", | ||
| "APP_ENV": "internal", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Changing APP_ENV to "internal"—verify runtime support
Ensure the app’s config/routes/feature flags handle APP_ENV="internal" (not just production/staging/development), otherwise builds may misconfigure endpoints or keys.
Run this to verify handling in the repo:
🏁 Script executed:
#!/bin/bash
# Where is APP_ENV read?
rg -nP -C2 '\bAPP_ENV\b' --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type-add 'jsx:*.jsx' --type-add 'js:*.js'
# Do we explicitly handle "internal"?
rg -nP -C2 '\binternal\b' --type=ts --type=tsx --type=js --type=jsx
# Any env mapping that might still point "internal" to development?
rg -nP -C2 'APP_ENV.*(development|staging|production)' --type=ts --type=tsx --type=js --type=jsx
# Any dotenv usage that could conflict with EXPO_NO_DOTENV=1?
rg -nP -C2 '(dotenv|react-native-dotenv|process\.env\.)' --type=ts --type=tsx --type=js --type=jsxLength of output: 6666
🏁 Script executed:
#!/bin/bash
find . -maxdepth 1 -type f -name ".env.*" -printLength of output: 18
Ensure a .env.internal file exists with all required variables
env.js loads .env.${APP_ENV} (via path.resolve) and its Zod schema includes "internal", but only .env.development is present—without .env.internal, internal builds will fail.
🤖 Prompt for AI Agents
In eas.json around line 63, APP_ENV is set to "internal" but there is no
corresponding .env.internal file; ensure a .env.internal file exists at the
project root containing all environment variables required by env.js/Zod schema
(match keys and formats used in other .env.* files), or change APP_ENV to an
existing environment (e.g., "development") if "internal" is not intended; add
the .env.internal file to version control or CI secrets as appropriate so
internal builds can load it via path.resolve.
Summary by CodeRabbit