Skip to content

CU-868ex18rd Fixing internal test builds #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucswift merged 1 commit into from
Sep 8, 2025
Merged

CU-868ex18rd Fixing internal test builds #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
},
"internal": {
"yarn": "1.22.22",
"distribution": "internal",
"ios": {
"image": "latest"
},
Expand All @@ -59,7 +60,7 @@
"image": "latest"
},
"env": {
"APP_ENV": "development",
"APP_ENV": "internal",
Copy link

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Changing APP_ENV to "internal"—verify runtime support

Ensure the app’s config/routes/feature flags handle APP_ENV="internal" (not just production/staging/development), otherwise builds may misconfigure endpoints or keys.

Run this to verify handling in the repo:

🏁 Script executed:

#!/bin/bash
# Where is APP_ENV read?
rg -nP -C2 '\bAPP_ENV\b' --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type-add 'jsx:*.jsx' --type-add 'js:*.js'

# Do we explicitly handle "internal"?
rg -nP -C2 '\binternal\b' --type=ts --type=tsx --type=js --type=jsx

# Any env mapping that might still point "internal" to development?
rg -nP -C2 'APP_ENV.*(development|staging|production)' --type=ts --type=tsx --type=js --type=jsx

# Any dotenv usage that could conflict with EXPO_NO_DOTENV=1?
rg -nP -C2 '(dotenv|react-native-dotenv|process\.env\.)' --type=ts --type=tsx --type=js --type=jsx

Length of output: 6666

🏁 Script executed:

#!/bin/bash
find . -maxdepth 1 -type f -name ".env.*" -print

Length of output: 18

Ensure a .env.internal file exists with all required variables
env.js loads .env.${APP_ENV} (via path.resolve) and its Zod schema includes "internal", but only .env.development is present—without .env.internal, internal builds will fail.

🤖 Prompt for AI Agents 
In eas.json around line 63, APP_ENV is set to "internal" but there is no
corresponding .env.internal file; ensure a .env.internal file exists at the
project root containing all environment variables required by env.js/Zod schema
(match keys and formats used in other .env.* files), or change APP_ENV to an
existing environment (e.g., "development") if "internal" is not intended; add
the .env.internal file to version control or CI secrets as appropriate so
internal builds can load it via path.resolve.

"EXPO_NO_DOTENV": "1",
"FLIPPER_DISABLE": "1"
}
Expand Down Expand Up @@ -97,4 +98,4 @@
"submit": {
"production": {}
}
}
}
Loading