fix(UpdatePlayerGameMetricsAction): use firstOrCreate to prevent race condition duplicate inserts#4587
Open
wescopeland wants to merge 2 commits intoRetroAchievements:masterfrom
Conversation
… condition duplicate inserts
Jamiras
reviewed
Feb 23, 2026
| continue; | ||
| if (!$hasExistingMetrics) { | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
Suggest just fetching this here to avoid an extra lookup in a few lines:
if ($isUntouchedSubset) {
$playerAchievementSet = PlayerAchievementSet...first();
if (!$playerAcheivementSet) {
continue;
}
} else {
$playerAchievementSet = PlayerAchievementSet::firstOrCreate(...);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:

Root Cause
Two concurrent
UpdatePlayerGameMetricsJobinstances for the same user+game can both query for an existingPlayerAchievementSet. Both find nothing, both try to INSERT, and the second one hits a unique constraint.We're basically hand-rolling a
first()+new+save()pattern. This PR replaces that pattern with afirstOrCreate()which should handle the operation atomically.