Turning ROS2-For-Unity into a package#94
Open
RobertoRoos wants to merge 3 commits intoRobotecAI:developfrom
Open
Turning ROS2-For-Unity into a package#94RobertoRoos wants to merge 3 commits intoRobotecAI:developfrom
RobertoRoos wants to merge 3 commits intoRobotecAI:developfrom
Conversation
Contributor
|
Hi, I had a similar idea which I implemented in my fork but with some changes:
If you want to implement some of these changes too I can rebase them on the current upstream since currently they are in a private repository together with other changes. |
Author
|
Sounds great @Deric-W ! I would suggest to make your own PR and we can probably drop mine. I didn't make any changes on purpose besides just getting the packaging stuff to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to #86 . It doesn't seem nice ROS2ForUnity is locked into the
Assets/directory, when for all intends and purposes it is a package. So I'd suggest we make it installable as an actual package.The most significant addition is just a
package.jsonfile.