Skip to content

feat: migrate vertx 4 to 5#678

Open
Sunil-SKS wants to merge 9 commits intoSAP:mainfrom
Sunil-SKS:feat/migrateVertx5
Open

feat: migrate vertx 4 to 5#678
Sunil-SKS wants to merge 9 commits intoSAP:mainfrom
Sunil-SKS:feat/migrateVertx5

Conversation

@Sunil-SKS
Copy link
Contributor

@Sunil-SKS Sunil-SKS commented Feb 11, 2026

The Future implementation has been removed from PendingDeployment to support the migration from Vert.x 4 to
Vert.x 5. The PendingDeployment class now returns objects directly, rather than Futures.

Migration document
https://vertx.io/docs/guides/vertx-5-migration-guide

  • Vertx used v 5.0.7
  • logback-classic - 1.5.19
  • commons-io:commons-io - 2.14.0
  • vertx-launcher-legacy-cli - 5.0.7
  • micrometer-registry-prometheus - 1.15.8

@Sunil-SKS Sunil-SKS requested a review from a team as a code owner February 11, 2026 08:24
@Sunil-SKS Sunil-SKS changed the title feat: Migrate vertx to latest version 5.0 feat: migrate vertx 4 to latest version vertx 5.0 Feb 11, 2026
@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch 7 times, most recently from 22b18ce to 37864c4 Compare February 26, 2026 08:38
@cla-assistant
Copy link

cla-assistant bot commented Feb 26, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Sunil-SKS
❌ halber
You have signed the CLA already but the status is still pending? Let us recheck it.

@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch 2 times, most recently from be5de9c to 3a625e1 Compare March 2, 2026 11:48
@Sunil-SKS Sunil-SKS changed the title feat: migrate vertx 4 to latest version vertx 5.0 feat: migrate vertx 4 to 5 Mar 2, 2026
@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch 9 times, most recently from 11567f6 to 67925f9 Compare March 4, 2026 09:11
Sunil-SKS and others added 7 commits March 4, 2026 11:02
Latest Vertx v 5.0.7
The Future implementation has been removed from PendingDeployment to support the migration from Vert.x 4 to Vert.x 5. The PendingDeployment class now returns objects directly, rather than Futures.
logback v 1.5.19
commons-io:commons v io:2.14.0
PetStoreTest -
If the BasicAuth added in the config then open apiendpoint will validate and adding BasicAuth is mandatory. As we send the empty basic auth this can be removed
@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch 2 times, most recently from 1bc7399 to 7534dbf Compare March 4, 2026 10:10
@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch from 913fcb4 to cdc6040 Compare March 4, 2026 10:29
@Sunil-SKS
Copy link
Contributor Author

Sunil-SKS commented Mar 5, 2026

Hello Team,

FYI

  • The code is moved to migration, hence this pull request can be closed
    [https://github.com/feat: remove future implementation from the pendingdeployment class #679]

    The Future implementation has been removed from PendingDeployment to support the migration from Vert.x 4 to
    Vert.x 5. The PendingDeployment class now returns objects directly, rather than Futures.

  • Migration document
    [https://vertx.io/docs/guides/vertx-5-migration-guide]

Please review the pull request

@Sunil-SKS Sunil-SKS force-pushed the feat/migrateVertx5 branch from 2e66157 to bb502c4 Compare March 5, 2026 12:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@Sunil-SKS Sunil-SKS marked this pull request as ready for review March 5, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants