feat: remove future implementation from the pendingdeployment class#679
feat: remove future implementation from the pendingdeployment class#679
Conversation
Sunil-SKS
force-pushed
the
feat/refactor
branch
3 times, most recently
from
7034ed6 to
d55b69b
Compare
Sunil-SKS
changed the title
| // complete and then undeploy it. pending deployment was completed successfully, undeploy will undeploy | ||
| // it, or otherwise will do nothing because a failed deployment results in a successful undeploy | ||
| return pendingDeployment.transform(deployResult -> pendingDeployment.undeploy()); | ||
| return pendingDeployment.undeploy(); |
There was a problem hiding this comment.
pendingDeployment.getDeployment().transform(result -> pendingDeployment.undeploy());
pendingDeployment.undeploy() will fail immediately with IllegalStateException if a deployment is still in progress. The old code used transform() to wait for completion; this waiting mechanism was removed, breaking the undeploy logic during partial deployment failures.
There was a problem hiding this comment.
The PendingDeployment is no longer a Future based so transform will not work any more, the undeploy will be called only when deployPromise fails in the line 157. The PendingDeployment will wait until the deployPromise is completed.
This pull request is merged with [https://github.com//pull/678], please review the changes in MIgration code . This pull request will be closed.
Changes - PendingDeployment
Sunil-SKS
force-pushed
the
feat/refactor
branch
from
d55b69b to
ee79c70
Compare
|
2 participants
The Future implementation has been removed from PendingDeployment to support the migration from Vert.x 4 to Vert.x 5. The PendingDeployment class now returns objects directly, rather than Futures.