Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Comments

Dev#47

Merged
mjorgecruz merged 8 commits intomainfrom
dev
Jan 7, 2025
Merged

Dev#47
mjorgecruz merged 8 commits intomainfrom
dev

Conversation

@Rui-Pedro-Pires
Copy link
Contributor

Pull Request Overview

Description

New features added, speed values and battery values can already be seen in the ui. Main.qml file as all the qml code to display this values, also created a class to handle the can bus communication.

Type of Change

  • 🐞 Bugfix (fixes an issue)
  • ✨ New Feature (introduces new functionality)
  • 📄 Documentation (adds or updates documentation)
  • 🔧 Configuration (adjusts project configuration or tooling)

Checklist

  • Code is thoroughly tested and operates as expected
  • Documentation has been updated to reflect these changes (if applicable)
  • No breaking changes introduced

Related Issues

Additional Context


Reviewer Checklist

  • Code follows project style and naming conventions.
  • No functionality is broken; code is well-tested.
  • Documentation and comments are clear.
  • No security vulnerabilities or performance issues are introduced.

Copy link
Contributor

@ziliolu ziliolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • Code follows project style and naming conventions.
  • No functionality is broken; code is well-tested.
  • Documentation and comments are clear.
  • No security vulnerabilities or performance issues are introduced.

Copy link
Contributor

@mjorgecruz mjorgecruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code follows project style and naming conventions.
  • No functionality is broken; code is well-tested.
  • Documentation and comments are clear.
  • No security vulnerabilities or performance issues are introduced.

@mjorgecruz mjorgecruz merged commit 921147a into main Jan 7, 2025
2 checks passed
Rui-Pedro-Pires pushed a commit that referenced this pull request Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants