Skip to content

Give thread names to ease debugging#367

Merged
zeromus merged 4 commits intoTASEmulators:masterfrom
linkmauve:thread-names
Jan 21, 2021
Merged

Give thread names to ease debugging#367
zeromus merged 4 commits intoTASEmulators:masterfrom
linkmauve:thread-names

Conversation

@linkmauve
Copy link
Collaborator

@linkmauve linkmauve commented Aug 31, 2020

This makes it much more easy to figure out why a given thread is consuming CPU time for instance.

This is still missing sound threads, but those depend on SDL apparently.

@zeromus
Copy link
Contributor

zeromus commented Aug 31, 2020

update rthreads from libretro-common before revising it

@linkmauve
Copy link
Collaborator Author

It is now merged. How do you usually deal with synchronising your vendor’d dependencies?

@zeromus
Copy link
Contributor

zeromus commented Sep 1, 2020

paste from vendor and check diffs to make sure there are not important local changes clobbered

@zeromus
Copy link
Contributor

zeromus commented Sep 27, 2020

what's the deal with this? have are we synchronized with libretro-common yet?

@zeromus
Copy link
Contributor

zeromus commented Jan 21, 2021

let's merge this and if it breaks the build, someone will have to update rthreads

@zeromus zeromus merged commit 44282bc into TASEmulators:master Jan 21, 2021
@MaddTheSane
Copy link
Contributor

…And breaks macOS: Mac's pthread_setname_np takes only one argument: the new thread name. And it can only be called from the thread you want to rename.

A quick and dirty fix is in #422.

@linkmauve linkmauve deleted the thread-names branch January 26, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments