Conversation
Pull Request Test Coverage Report for Build 21597349897Details
💛 - Coveralls |
This will be an extra pr Related: #1332
oliverklee
force-pushed
the
task/1332-make-plugin-ctype-without-wizard
branch
from
cdebf22 to
45941cd
Compare
oliverklee
changed the title
CType
oliverklee
added this to the
4.0.0: Drop support for TYPO3 11LTS and PHP 7.4/8.0, add support for 13LTS milestone
|
|
||
| excludePaths: | ||
| # We need this Class only for V12. So we exclude it here | ||
| - ../../Classes/Upgrades/AbstractListTypeToCTypeUpdate.php |
There was a problem hiding this comment.
This is related to the upgrade wizard (which is not part of this PR). So we don't need the changed to this file in this PR.
| ->autowire() | ||
| ->autoconfigure(); | ||
| ->autoconfigure() | ||
| ->public(); |
There was a problem hiding this comment.
Is this needed for this PR? If so, why?
| /** | ||
| * Register TeaIndex as "Insert Record" | ||
| */ | ||
| ExtensionManagementUtility::addToInsertRecords('tea_index'); |
There was a problem hiding this comment.
If we do this, we should have the other plugins as well.
| ); | ||
| foreach ($plugins as $contentType) { | ||
| // This makes the plugin selectable in the BE. | ||
| ExtensionUtility::registerPlugin( |
There was a problem hiding this comment.
ExtensionUtility::registerPlugin returns the plugin signature. Can we (re-)use it for ExtensionManagementUtility::addToAllTCAtypes and ExtensionManagementUtility::addPiFlexFormValue?
| <target>Teeliste</target> | ||
| </trans-unit> | ||
| <trans-unit id="plugin.tea_index.description"> | ||
| <source>Tea plugin to show the listview.</source> |
There was a problem hiding this comment.
| <source>Tea plugin to show the listview.</source> | |
| <source>Tea plugin to show the list view.</source> |
(also in the other file)
| ,1,1,"list","Tea index","tea_teaindex","<?xml version=""1.0"" encoding=""utf-8"" standalone=""yes"" ?> | ||
| ,"uid","pid","CType","header","pi_flexform" | ||
| ,1,1,"tea_teaindex","Tea index","<?xml version=""1.0"" encoding=""utf-8"" standalone=""yes"" ?> | ||
| <T3FlexForms> |
There was a problem hiding this comment.
We should indent the XML to align with the <?xml again.
| "psr/http-message": "^1.0.1", | ||
| "typo3/cms-core": "^12.4.41", | ||
| "typo3/cms-extbase": "^12.4.41 || ^13.4", | ||
| "typo3/cms-fluid": "^12.4.41 || ^13.4", |
There was a problem hiding this comment.
No, this needs to stay as we have Fluid templates.
| ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT | ||
| ); | ||
|
|
||
| ExtensionManagementUtility::addPageTSConfig('@import \'EXT:tea/Configuration/TSconfig/Page/ContentElementWizard.tsconfig\''); |
There was a problem hiding this comment.
This file does not exist, and this PR does not introduce it. So this line should be removed.
4 participants
Part of #1332