[TASK] Make the plugin a CType
#1960
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,68 @@ | ||
| <?php | ||
|
|
||
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
| use TYPO3\CMS\Core\Utility\GeneralUtility; | ||
| use TYPO3\CMS\Extbase\Utility\ExtensionUtility; | ||
|
|
||
| defined('TYPO3') || die(); | ||
|
|
||
| call_user_func( | ||
| static function (): void { | ||
| /** | ||
| * Add new select group for content element | ||
| */ | ||
| ExtensionManagementUtility::addTcaSelectItemGroup( | ||
| 'tt_content', | ||
| 'CType', | ||
| 'tea', | ||
| 'LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_tea.pluginGroup', | ||
| 'after:default' | ||
| ); | ||
|
|
||
| /** | ||
| * Register all plugins | ||
| */ | ||
| $plugins = ['tea_index', 'tea_show', 'tea_front_end_editor']; | ||
|
|
||
| foreach ($plugins as $contentType) { | ||
| // This makes the plugin selectable in the BE. | ||
| ExtensionUtility::registerPlugin( | ||
|
Contributor
There was a problem hiding this comment.
|
||
| // extension name, matching the PHP namespaces (but without the vendor) | ||
| 'Tea', | ||
| // arbitrary, but unique plugin name (not visible in the BE) | ||
| GeneralUtility::underscoredToUpperCamelCase($contentType), | ||
| // plugin title, as visible in the drop-down in the BE | ||
| 'LLL:EXT:tea/Resources/Private/Language/locallang.xlf:plugin.' . $contentType, | ||
| // the icon visible in the drop-down in the BE | ||
| 'EXT:tea/Resources/Public/Icons/Extension.svg', | ||
| 'tea' | ||
| ); | ||
|
|
||
| } | ||
|
|
||
| // Add the FlexForm to the show item list | ||
| ExtensionManagementUtility::addToAllTCAtypes( | ||
| 'tt_content', | ||
| '--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:tabs.plugin, pi_flexform', | ||
| 'tea_teaindex', | ||
| 'after:palette:headers' | ||
| ); | ||
| // Add the flexform configuration for the TeaIndex plugin. | ||
| ExtensionManagementUtility::addPiFlexFormValue( | ||
| '*', | ||
| 'FILE:EXT:tea/Configuration/FlexForms/TeaIndex.xml', | ||
| 'tea_teaindex' | ||
| ); | ||
| // Add the flexform configuration for the FE editor plugin. | ||
| ExtensionManagementUtility::addPiFlexFormValue( | ||
| '*', | ||
| 'FILE:EXT:tea/Configuration/FlexForms/FrontEndEditor.xml', | ||
| 'tea_front_end_editor' | ||
| ); | ||
|
|
||
| /** | ||
| * Register TeaIndex as "Insert Record" | ||
| */ | ||
| ExtensionManagementUtility::addToInsertRecords('tea_index'); | ||
|
Contributor
There was a problem hiding this comment. If we do this, we should have the other plugins as well. |
||
| } | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,15 @@ | |
| <trans-unit id="tx_tea_domain_model_tea.hidden"> | ||
| <source>Visible</source> | ||
| </trans-unit> | ||
| <trans-unit id="tx_tea_domain_model_tea.pluginGroup"> | ||
| <source>Tea</source> | ||
| </trans-unit> | ||
| <trans-unit id="plugin.tea_index.title"> | ||
| <source>Tea Index</source> | ||
| </trans-unit> | ||
| <trans-unit id="plugin.tea_index.description"> | ||
| <source>Tea plugin to show the listview.</source> | ||
| </trans-unit> | ||
| </body> | ||
| </file> | ||
| </xliff> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| "tt_content" | ||
| ,"uid","pid","CType","header","pi_flexform" | ||
| ,1,1,"tea_teafrontendeditor","Tea FrontEnd Editor","<?xml version=""1.0"" encoding=""utf-8"" standalone=""yes"" ?> | ||
| <T3FlexForms> | ||
| <data> | ||
| <sheet index=""pagesAndFolders""> | ||
| <language index=""lDEF""> | ||
| <field index=""persistence.storagePid""> | ||
| <value index=""vDEF"">2</value> | ||
| </field> | ||
| </language> | ||
| </sheet> | ||
| </data> | ||
| </T3FlexForms>" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| "tt_content" | ||
| ,"uid","pid","CType","header","pi_flexform" | ||
| ,1,1,"tea_teaindex","Tea index","<?xml version=""1.0"" encoding=""utf-8"" standalone=""yes"" ?> | ||
| <T3FlexForms> | ||
|
Contributor
There was a problem hiding this comment. We should indent the XML to align with the |
||
| <data> | ||
| <sheet index=""pagesAndFolders""> | ||
|
|
@@ -18,4 +18,4 @@ | |
| </sheet> | ||
| </data> | ||
| </T3FlexForms>" | ||
| ,2,3,"tea_teashow","Tea show","" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,6 @@ | |
| "psr/http-message": "^1.0.1", | ||
| "typo3/cms-core": "^12.4.41", | ||
| "typo3/cms-extbase": "^12.4.41 || ^13.4", | ||
|
Contributor
There was a problem hiding this comment. No, this needs to stay as we have Fluid templates. |
||
| "typo3/cms-frontend": "^12.4.41 || ^13.4" | ||
| }, | ||
| "require-dev": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| use TTN\Tea\Controller\FrontEndEditorController; | ||
| use TTN\Tea\Controller\TeaController; | ||
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
| use TYPO3\CMS\Extbase\Utility\ExtensionUtility; | ||
|
|
||
| defined('TYPO3') or die('Access denied.'); | ||
|
|
@@ -21,7 +22,8 @@ | |
| // non-cacheable actions | ||
| [ | ||
| TeaController::class => '', | ||
| ], | ||
| ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT | ||
| ); | ||
| ExtensionUtility::configurePlugin( | ||
| 'Tea', | ||
|
|
@@ -31,7 +33,8 @@ | |
| ], | ||
| [ | ||
| TeaController::class => '', | ||
| ], | ||
| ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT | ||
| ); | ||
|
|
||
| // This makes the plugin available for front-end rendering. | ||
|
|
@@ -49,5 +52,8 @@ | |
| // All actions need to be non-cacheable because they either contain dynamic data, | ||
| // or because they are specific to the logged-in FE user (while FE content is cached by FE groups). | ||
| FrontEndEditorController::class => 'index, edit, update, create, new, delete', | ||
| ], | ||
| ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT | ||
| ); | ||
|
|
||
| ExtensionManagementUtility::addPageTSConfig('@import \'EXT:tea/Configuration/TSconfig/Page/ContentElementWizard.tsconfig\''); | ||
|
Contributor
There was a problem hiding this comment. This file does not exist, and this PR does not introduce it. So this line should be removed. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to the upgrade wizard (which is not part of this PR). So we don't need the changed to this file in this PR.