Remove taintedness as it was removed in Ruby 3.2#56
Open
jkorpela wants to merge 1 commit intoTwP:masterfrom
Open
Remove taintedness as it was removed in Ruby 3.2#56jkorpela wants to merge 1 commit intoTwP:masterfrom
jkorpela wants to merge 1 commit intoTwP:masterfrom
Conversation
jkorpela
changed the title
smortex
approved these changes
Apr 19, 2023
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
This fix the inifile gem with Ruby 3.2 💯 .
|
For reference, these function have been no-op since Ruby 2.7 and where removed in Ruby 3.2: @TwP, do you still have enough cycles to handle this gem and do release? |
Closed
|
There are also test for |
|
@jkorpela couid you update your PR to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging inifiles does not work because in dup it attempts to taint which is no longer available in 3.2.