Skip to content

Conversation

@eodorfman111
Copy link

This pull request addresses the bug described in Wildbook issue #1210 (Reference keywords not appearing in the annotation export).

Changes

  • The EncounterAnnotationExportExcelFile now writes the correct Keyword object to the "Reference" column instead of using the previous LabelledKeyword, ensuring that reference keywords populate in the export.
  • The check for the "Reference" keyword is now case-insensitive (equalsIgnoreCase) so that different capitalizations are handled.
  • The export loop now breaks as soon as the reference keyword is found to avoid redundant processing.

Issue link

Fixes Wildbook/Wildbook#1210

Please let me know if any additional changes or tests are needed.

fix(email): correct legal statement and link formatting in encounter submission mail (WildMeOrg#1209)
Use equalsIgnoreCase to match the 'Reference' keyword when exporting annotation keywords. Ensures the Reference column is populated correctly. Fixes WildMeOrg#1210.
Ensure the Reference column in annotation export writes the matched keyword (kw) instead of using a labelled keyword. Also set keywordFound correctly. Addresses Wildbook issue WildMeOrg#1210.
@naknomum
Copy link
Member

naknomum commented Nov 3, 2025

thanks for your work on this @eodorfman111 . i have looked at the existing code and what it was doing and talked with the team. it seems the previous code was focused on only Keywords that had a name of Reference. this seems to have been a choice that no longer is relevant.

so what we need instead is for the export to populate the column with all Keywords. this should be more similar to the way LabeledKeywords is done in the block before Keywords -- basically no check on value, just add every keyword to the column. for reference on what is needed, you can check out this community post.

please let me know if you have any questions. feel free to start another PR if you wish to take on this issue with these changes.

@goddesswarship
Copy link
Contributor

@eodorfman111 Checking in to see if you need any help with the review @naknomum provided on your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotation Export doesn't populate data for keywords

3 participants