Skip to content

Be more verbose why exactly device tree parsing failed#4

Open
Spacefish wants to merge 46 commits intoXilinx:masterfrom
Spacefish:improve_devicetree_parsing_errors
Open

Be more verbose why exactly device tree parsing failed#4
Spacefish wants to merge 46 commits intoXilinx:masterfrom
Spacefish:improve_devicetree_parsing_errors

Conversation

@Spacefish
Copy link

We patched this internally to debug this better, as we are writing our own custom device-tree.
So just wanted to share it / adhere to GPL as well!

shikharmxlnx and others added 30 commits October 12, 2018 15:15
Before acquiring dru clock, during probe, verify if dru feature is enabled in IP
configuration. This can be checked by exammining the dru presence flag in
device-tree

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
XVidC_GetVideoModeIdExtensive() API was getting called with
isExtensive flag as false which leads to selection of wrong VmID from video timing
table.
Now we are calling with isExtensive as TRUE.

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Audio code added

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Disable IbufD when cable disconnect

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Update of all driver code

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
This to enable the dru clock if it is enabled in DT

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Updated comment header in audio files
Removed warnings in audio code
Updated the DT documentation

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Update AES audio header parsing in HDMI Rx audio

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Updated to new drivers version

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Update related to snd-pcm name

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Changed error to warning for non supported fourcc

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
si5324 driver is now part of linux_xlnx and located at
drivers/clk path and documentation is present at
Documentation/devicetree/bindings/clock/silabs,si5324.txt

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Enabling audio in TXstreamupCallback

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Removed the AES audio header parsing logic

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Update supported audio formats and sampling rates

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
… count

Start audio capture only if audio is detected through channel count

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Added calculation of feild1 parameters for interlaced resolution

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
Drivers update till 20181004

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
TMDS clock ratio flag is set, when resolution is 4k and 60fps.
Audio recovery block uses this flag to run audio ot 4k@60fps.

Signed-off-by: Shikhar Mishra <shikharm@xilinx.com>
hdmitx: use new drm framework API in hdmi tx driver
hdmirx: use new audio framework API in audio driver

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
- After reading edid, if the sink is non HDMI sink, stream type is set
to DVI, else HDMI.
- Also updated the DRM when there is failure in reading EDID

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Code has been modified to support the auto generated
device tree so that minimal modification is needed in the DT.

Modification still needed after the implementation are
- Adding si5324 and dp159 node (other board specific details not part
				of hdf) in axi_iic node
- Adding refhdmi clock node for si5324
- Adding dru_clk in vphy which is also external
- For hdcp design, adding hdmi_eeprom in axi_iic node
- Changing the default value of "xlnx,vformat" in "v_drm_dmaengine_drv"
to BG24 otherwise problem during first modeset
- For hdcp design, reg-name feild needs to be added in RX and TX node
to access the HDCP block key mngmnt block using reg name.

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Also solve the app hang issue on using drm_kms_helper_hotplug_event
as apart from notifying user space about hotplug, it also calls
output_poll_changed of drm device that is used to inform the fbdev helper
of output changes. It is of no use here.

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Updated the document for HDMI TX, HDMI RX and Vphy DT nodes

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
patch includes changes for lookup table for N, index entry for
sample rate index and removing fixed N value for 4k.

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
YUV420 10bit	MEDIA_BUS_FMT_VYYUYY10_4X20
YUV422 10bit	MEDIA_BUS_FMT_UYVY10_1X20
YUV444 10bit	MEDIA_BUS_FMT_VUY10_1X30
RGB 10bit	MEDIA_BUS_FMT_RBG101010_1X30

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Shikhar Mishra and others added 16 commits April 25, 2019 10:10
For 2019.1 driver, xlnx,max-bits-per-component is now should be part of
HDMI RX device tree.
Without this, RX probe will fail. This feild is part of IP configuration

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
This code will parse "xlnx,use-gt-ch4-hdmi" parameter from DT.
So above parameter also needed to be there in DT

Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
Signed-off-by: Shikhar Mishra <shikhar.mishra@xilinx.com>
The compilation with v5.4 kernel fails as xilinx-vip.h is include path
is not added. This is needed as the driver depends on
xvip_enum_mbus_code(). Since the driver should ideally include either
from local dir or from include/ dir only, the xvip_enum_mbus_code() is
added to driver directly as xhdmi_enum_mbus_code().

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
This fixes compilation error caused by moving of
drm_helper_probe_single_connector_modes() prototype to new header file.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
Update all the drivers upto 20200330.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
Add support for Versal HDMI GT controller PHY. This adds two new
required parameters for Rx and Tx FRL reference clock.

The compatible string is also updated for Versal.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
This patch adds support for the Versal HDMI GT controller PHY in the
core driver area and the wrapper drivers. To ensure that there is only
driver common between Versal and non-Versal platforms, a flag "isvphy" is
introduced in the wrapper drivers.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
The GT values need to be programmed based on the Tx PLL and Rx PLL type.
These can either be LCPLL or RPLL type. The Tx PLL type and Rx PLL type
will not be same. This patch updates the values to be programmed in GT
for Versal.

The Reset PLL register reset in HDMI GT Controller (0x14 offset) is
removed too.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants