Add Objects Access API spec #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 4, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 4, 2025
Based on [1] at 7d4c215. A few outstanding questions on the PR; have implemented based on my current understanding of what's there. Development approach similar to that described in 4494033. Also, have not implemented the specification points related to RTO2's channel mode checking for same reasons as mentioned there. [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 4, 2025
Based on [1] at 7d4c215. A few outstanding questions on the PR; have implemented based on my current understanding of what's there. Development approach similar to that described in 4494033. Also, have not implemented the specification points related to RTO2's channel mode checking for same reasons as mentioned there. [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 4, 2025
I didn't do this in 4494033 because the specification hadn't yet specified the status code (it was an outstanding question on the PR at time of implementing), but the newly-written spec [1] for other LiveMap getter methods _does_ specify the status code as being 400. So DRY up the creation of these errors, and supply a status code (assuming that the spec will be updated to specify 400 for these existing ones too). [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 4, 2025
Based on [1] at 7d4c215. A few outstanding questions on the PR; have implemented based on my current understanding of what's there. Development approach similar to that described in 4494033. Also, have not implemented the specification points related to RTO2's channel mode checking for same reasons as mentioned there. [1] ably/specification#341
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jul 7, 2025
Spec IDs from [1] [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 7, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 7, 2025
I didn't do this in 4494033 because the specification hadn't yet specified the status code (it was an outstanding question on the PR at time of implementing), but the newly-written spec [1] for other LiveMap getter methods _does_ specify the status code as being 400. So DRY up the creation of these errors, and supply a status code (assuming that the spec will be updated to specify 400 for these existing ones too). [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 7, 2025
Based on [1] at 7d4c215. A few outstanding questions on the PR; have implemented based on my current understanding of what's there. Development approach similar to that described in 4494033. Also, have not implemented the specification points related to RTO2's channel mode checking for same reasons as mentioned there. [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 8, 2025
I didn't do this in cb427d8 because the specification hadn't yet specified the status code (it was an outstanding question on the PR at time of implementing), but the newly-written spec [1] for other LiveMap getter methods _does_ specify the status code as being 400. So DRY up the creation of these errors, and supply a status code (assuming that the spec will be updated to specify 400 for these existing ones too). [1] ably/specification#341
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 8, 2025
Based on [1] at 7d4c215. A few outstanding questions on the PR; have implemented based on my current understanding of what's there. Development approach similar to that described in cb427d8. Also, have not implemented the specification points related to RTO2's channel mode checking for same reasons as mentioned there. [1] ably/specification#341
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jul 22, 2025
Spec IDs from [1] [1] ably/specification#341
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jul 22, 2025
Spec IDs from [1] [1] ably/specification#341
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Jul 22, 2025
Spec IDs from [1] [1] ably/specification#341
VeskeR
force-pushed
the
PUB-1041/object-sync
branch
from
dd25dca to
fc46aed
Compare
VeskeR
force-pushed
the
objects-access-api
branch
from
7791cd3 to
24e151e
Compare
lawrence-forooghian
approved these changes
Sep 4, 2025
VeskeR
force-pushed
the
PUB-1041/object-sync
branch
from
bfcf05b to
b3e06dc
Compare
VeskeR
force-pushed
the
objects-access-api
branch
from
24e151e to
08a837d
Compare
sacOO7
reviewed
Sep 5, 2025
sacOO7
reviewed
Sep 5, 2025
sacOO7
reviewed
Sep 5, 2025
sacOO7
approved these changes
Sep 5, 2025
Collaborator
sacOO7
left a comment
sacOO7
left a comment
There was a problem hiding this comment.
Except from the minor comments ( makes spec explicit and more clear to understand )
LGTM
Adds spec for `LiveMap.size`, `LiveMap.entries`, `LiveMap.keys` and `LiveMap.values`
VeskeR
force-pushed
the
objects-access-api
branch
from
0bff266 to
dba8ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spec for
LiveMap.size,LiveMap.entries,LiveMap.keysandLiveMap.values