Remove "quick listener check" and don't mute connection#7
Open
zstyblik wants to merge 1 commit intoalexcesaro:masterfrom
Open
Remove "quick listener check" and don't mute connection#7zstyblik wants to merge 1 commit intoalexcesaro:masterfrom
zstyblik wants to merge 1 commit intoalexcesaro:masterfrom
Conversation
Commit removes "quick listener check" which mutes connection and returns error when listener isn't available at the time of inicialization. It seems as this there is no need to scrap connection, because when remote endpoint comes around later, metrics will be received by that endpoint just fine. Fixes alexcesaro#6
|
+1, had the same issue in tests but this has very little chance to happen in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit removes "quick listener check" which mutes connection and returns error
when listener isn't available at the time of inicialization.
It seems as this there is no need to scrap connection, because when remote
endpoint comes around later, metrics will be received by that endpoint just
fine.
Fixes #6