Invert time test#2
Merged
annismckenzie merged 1 commit intoalfatraining:0-minor-fixesfrom Sep 29, 2025
Merged
Conversation
Rather than reading the value of `Now` on `ReconcilerTestCase`, the field is used to set the time for that test case and the set value is asserted within the reconcile. Signed-off-by: Scott Andrews <scott@andrews.me>
Author
|
Follow up to reconcilerio#651 |
|
@scothis didn't you mean to target reconcilerio/runtime instead of alfatraining/runtime? |
Author
Yes. I don't have permission to edit the PR directly, so sending a PR to the PR. |
annismckenzie
approved these changes
Sep 28, 2025
annismckenzie
left a comment
annismckenzie
left a comment
There was a problem hiding this comment.
I like your changes. There's one nit but I'll let you decide whether to apply that – approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than reading the value of
NowonReconcilerTestCase, the field is used to set the time for that test case and the set value is asserted within the reconcile.