Merged
Conversation
Signed-off-by: Daniel Lohse <info@asapdesign.de>
…` set Signed-off-by: Daniel Lohse <info@asapdesign.de>
annismckenzie
force-pushed
the
0-minor-fixes
branch
from
98c2cff to
99615bc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 57.28% 59.48% +2.19%
==========================================
Files 39 39
Lines 4507 4507
==========================================
+ Hits 2582 2681 +99
+ Misses 1811 1716 -95
+ Partials 114 110 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@annismckenzie thanks for this. The intent behind the |
Rather than reading the value of `Now` on `ReconcilerTestCase`, the field is used to set the time for that test case and the set value is asserted within the reconcile. Signed-off-by: Scott Andrews <scott@andrews.me>
Member
|
Opened alfatraining#2 |
Invert time test
Contributor
Author
|
I'll rebase after #654 was merged if that's alright with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While upgrading one of our projects to the latest release I came across a few nits in the code and decided to put them into a separate branch and open a PR.
RetrieveNowmethod is misspelled across 3 comments so it was probably copy'n'pasted.tc.Now == (time.Time{})linters suggest to usetime.Equalinstead but what's really tested here is whether an explicit time has been set or not so checkingtime.Now.IsZero()looks like the prudent thing to do. I couldn't find unit tests for the testing facilities so I added one for this. I can of course also remove this again.Thank you for your hard work, using this library has started to improve our operators massively.