Skip to content

[C++][CMake] Fix install/export targets and Windows runtime handling #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanmoyPaul12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[C++][CMake] Fix install/export targets and Windows runtime handling #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ macro(build_graphar)
else()
add_library(graphar SHARED ${CORE_SRC_FILES})
endif()
install_graphar_target(graphar)
# install_graphar_target(graphar)
target_compile_features(graphar PRIVATE cxx_std_17)
target_include_directories(graphar PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty)
target_link_libraries(graphar PRIVATE ${CMAKE_DL_LIBS})
Expand Down Expand Up @@ -334,7 +334,7 @@ macro(build_graphar_with_arrow_bundled)
else()
add_library(graphar SHARED ${CORE_SRC_FILES})
endif()
install_graphar_target(graphar)
#install_graphar_target(graphar)
target_compile_features(graphar PRIVATE cxx_std_17)
target_include_directories(graphar PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty)
target_include_directories(graphar SYSTEM BEFORE PRIVATE ${GAR_ARROW_INCLUDE_DIR})
Expand Down Expand Up @@ -497,6 +497,14 @@ endif()
# ------------------------------------------------------------------------------
# Install
# ------------------------------------------------------------------------------
install(TARGETS graphar
EXPORT graphar-targets
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} # .lib / .a
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} # .so / .dylib
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} OPTIONAL # .dll / executables
)


install(DIRECTORY ${PROJECT_SOURCE_DIR}/src/graphar
DESTINATION include
FILES_MATCHING
Expand Down
Loading