Work around invalid device port settings#51
Open
bugadani wants to merge 1 commit intoberkowski:masterfrom
Open
Work around invalid device port settings#51bugadani wants to merge 1 commit intoberkowski:masterfrom
bugadani wants to merge 1 commit intoberkowski:masterfrom
Conversation
|
Hello, is this going to be merged? |
nemecec
added a commit
to nemecec/mio-serial
that referenced
this pull request
Feb 2, 2026
Some USB-CDC devices (e.g., ESP32-C6) cannot provide complete port settings via Windows APIs. Instead of failing with "Invalid data bits setting encountered", gracefully skip settings that cannot be read. Fixes issue berkowski#41. Inspired by upstream PR berkowski#51.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (when trying to communicate with an ESP32-C6 MCU over its built-in USB-CDC hardware block), windows is not able to provide some port settings, like the number of data bits.
mio-serialbails with an error in this situation, which does not result in a very good user experience. As this is a virtual COM port, these settings don't make a difference. As the previous behaviour was an error, ignoring that error and port setting should be a net improvement in device compatibility.Closes #41