identicon: fix build with C++20 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fixes the FTBFS on Fedora 44 mass-rebuild with GCC 16. |
C++20 changed the type uf u8"str" to char8_t, which can't be assigned to a char pointer without casting. - replace "constexpr" with "const" array, because reinterpret_cast is per C++ standard not a constant expression - move array initialization from the class declaration to the class implementation, just like the two color arrays - wrap u8 strings in "reinterpret_cast< const char* >()" to make a C++20 compiler happy
stefanb2
force-pushed
the
topic-fix-build-with-cplusplus20
branch
from
d96080c to
cde65d6
Compare
Contributor
Author
|
Installer packaging step in Windows build is broken, because |
Contributor
Author
This issue is addressed by PR #60. |
bkueng
approved these changes
Jan 29, 2026
Owner
bkueng
left a comment
bkueng
left a comment
There was a problem hiding this comment.
Looks good, thanks.
We could directly set the C++ standard to 20 in the CMakeLists.txt (set (CMAKE_CXX_STANDARD 20)), then it's also used for older compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 changed the type uf u8"str" to char8_t, which can't be assigned to a char pointer without casting.