[TESTING ONLY]

[matejvasek]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.72%. Comparing base (6fc092b) to head (d593b0d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   79.72%   79.72%   -0.00%     
==========================================
  Files         176      176              
  Lines       13263    13277      +14     
==========================================
+ Hits        10573    10584      +11     
- Misses       2021     2022       +1     
- Partials      669      671       +2     

Flag	Coverage Δ
os_linux	78.65% <85.72%> (-<0.01%)	⬇️
os_macos	76.35% <76.20%> (+0.01%)	⬆️
os_windows	79.11% <85.72%> (-<0.01%)	⬇️
unit	79.72% <85.72%> (-<0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jjbustamante]

I created simple acceptance test with this code, and @matejvasek you were right I got the following error:

  Host Settings:
          Binds: 'pack-cache-some-org_gbmqdqekqf_latest-bc166514d2fd.build:/cache pack-layers-smuiylvmuq:/layers pack-app-ohcxidehgd:/workspace'
          Network Mode: 'host'
        ERROR: failed to build: executing lifecycle: failed to create 'creator' container: "specify mac-address per network" requires API version 1.44, but the Docker daemon API version is 1.38

We are actually using Docker API version I will try to update and push the acceptance test to this branch

[jjbustamante]

Damn, the linux runner is using Docker Server 24.0.9, and this version only support version 1.43

[jjbustamante]

This table shows the Docker version used by pack and the runners, we need to move to 25.0 in order to support setting the mac-address but, the ubuntu latest runner doesn't support that version yet, also, we will need to update the self hosted windows runner

Docker version	Maximum API version	Runner Version	Note
26.0	1.45
25.0	1.44		Expected version
24.0	1.43	Linux runner
23.0	1.42
20.10	1.41	Windows runner	<- I upgraded to this in this PR
19.03	1.40
18.09	1.39
18.06	1.38		current pack version