Skip to content

Comments

feat(25.04): add golang-1.24#818

Merged
cjdcordeiro merged 7 commits intocanonical:ubuntu-25.04from
zhijie-yang:ROCKS-2300/golang-25.04-new
Jan 14, 2026
Merged

feat(25.04): add golang-1.24#818
cjdcordeiro merged 7 commits intocanonical:ubuntu-25.04from
zhijie-yang:ROCKS-2300/golang-25.04-new

Conversation

@zhijie-yang
Copy link
Collaborator

@zhijie-yang zhijie-yang commented Dec 17, 2025 •
edited
Loading

Proposed changes

This PR is the FP of #797. This PR supersedes #598 since it's a rework based on #797.

In this PR the following changes are made:

  1. All the existences of "golang-1.22" are replaced by "golang-1.24"
  2. The slices for make is additionally included, as there are now make files in the golang-1.24-src.

Related issues/PRs

Forward porting

#821

Checklist

Additional Context

@ROCKsBot ROCKsBot requested a review from a team December 18, 2025 01:37
@zhijie-yang zhijie-yang mentioned this pull request Dec 18, 2025
Open
3 tasks
@lczyk lczyk added the forward port missing The forward port is missing. label Dec 18, 2025
@lczyk
Copy link
Collaborator

lczyk commented Dec 18, 2025

@lczyk lczyk mentioned this pull request Dec 18, 2025
Closed
3 tasks
@zhijie-yang zhijie-yang mentioned this pull request Jan 6, 2026
Open
3 tasks
@zhijie-yang zhijie-yang removed the forward port missing The forward port is missing. label Jan 6, 2026
@zhijie-yang
Copy link
Collaborator Author

zhijie-yang commented Jan 6, 2026

It's already in the golang-1.24-go_go-env slice.

@lczyk lczyk added the forward port missing The forward port is missing. label Jan 14, 2026
@lczyk
Copy link
Collaborator

lczyk commented Jan 14, 2026

adding 'forward port missing' for the same reason as #821

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question, but overall looks like a straightforward Pr based on #797 👍

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more suggestion -- adding GOTOOLCHAIN directive to force go to run with this particular compiler

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions based on this comment

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions based on this comment

zhijie-yang and others added 2 commits January 14, 2026 14:01
@zhijie-yang
chore(25.04): adjust src_bash-scripts
b2a2e58
@zhijie-yang @lczyk
chore(25.04): new find pattern to remove test files
eeb5712 
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
@cjdcordeiro cjdcordeiro merged commit f09f9fe into canonical:ubuntu-25.04 Jan 14, 2026
49 of 50 checks passed
@lczyk lczyk mentioned this pull request Jan 14, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@lczyk lczyk lczyk approved these changes

Assignees

No one assigned

Labels

forward port missing The forward port is missing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhijie-yang @lczyk @cjdcordeiro