Skip to content

Comments

feat(25.10): add golang-1.24#821

Open
zhijie-yang wants to merge 10 commits intocanonical:ubuntu-25.10from
zhijie-yang:golang-25.10
Open

feat(25.10): add golang-1.24#821
zhijie-yang wants to merge 10 commits intocanonical:ubuntu-25.10from
zhijie-yang:golang-25.10

Conversation

@zhijie-yang
Copy link
Collaborator

@zhijie-yang zhijie-yang commented Dec 18, 2025 •
edited
Loading

Proposed changes

This is a straight forward port from #818 . The first commit is cherry-picked, and the delta is overlayed as the second commit.

Related issues/PRs

Forward porting

The FP #825 of this PR is a quasi-FP, which actually provides golang-1.25 on 26.04.

Checklist

Additional Context

@zhijie-yang zhijie-yang changed the title Golang 25.10 feat(25.10): add golang-1.24 Dec 18, 2025
@zhijie-yang zhijie-yang mentioned this pull request Dec 18, 2025
Merged
3 tasks
@zhijie-yang zhijie-yang added the forward port missing The forward port is missing. label Dec 18, 2025
@lczyk
Copy link
Collaborator

lczyk commented Dec 18, 2025

@zhijie-yang
Copy link
Collaborator Author

zhijie-yang commented Dec 18, 2025

It's already in the golang-1.24-go_go-env slice.

@ROCKsBot ROCKsBot requested a review from a team December 19, 2025 01:36
@zhijie-yang zhijie-yang removed the forward port missing The forward port is missing. label Jan 6, 2026
@lczyk lczyk added the forward port missing The forward port is missing. label Jan 8, 2026
@lczyk
Copy link
Collaborator

lczyk commented Jan 8, 2026

as discussed, golang-1.24 is available in resolute so adding the forward port missing label back on for now

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing test_bash-scripts.sh ?

https://github.com/canonical/chisel-releases/pull/818/changes#diff-ab14272847ca3634fd8c3912196bdd9ff47fff3ddc4cfbc609c0ad997724a265R1

other than that looks great 👍

lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
lczyk
lczyk approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions based on this comment

@zhijie-yang
Copy link
Collaborator Author

zhijie-yang commented Jan 14, 2026

Oops, the test_bash-scripts.sh should not exist... These scripts are not able to be tested as per the comment in the code. ref

zhijie-yang and others added 2 commits January 14, 2026 14:37
@zhijie-yang
feat(25.10): add cgo-support
007bd80
@zhijie-yang @lczyk
chore(25.10): misc changes from code review
0760937 
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
@lczyk lczyk mentioned this pull request Jan 14, 2026
Open
3 tasks
@lczyk
Copy link
Collaborator

lczyk commented Jan 14, 2026

removing forward port missing since forward port now exists:

@lczyk lczyk removed the forward port missing The forward port is missing. label Jan 14, 2026
@lczyk lczyk self-assigned this Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Test Coverage

Average Total Coverage: 10.12%

Arch: aarch64

Coverage: 10.12%

golang: 🌂 0.00% (24 missing) 
golang_api
golang_bash-scripts
golang_bins
golang_build-tools
golang_cgo-support
golang_cgo-tools
golang_cmd-src
golang_copyright
golang_core
golang_debug-tools
golang_dist-tools
golang_doc-tools
golang_go-build-src
golang_go-env
golang_headers
golang_internal-src
golang_libs
golang_minimal
golang_profiling-tools
golang_runtime-src
golang_src-with-tests
golang_symlinks
golang_testing-tools
golang_time-src
golang-1.24: 🌂 0.00% (24 missing) 
golang-1.24_api
golang-1.24_bash-scripts
golang-1.24_bins
golang-1.24_build-tools
golang-1.24_cgo-support
golang-1.24_cgo-tools
golang-1.24_cmd-src
golang-1.24_copyright
golang-1.24_core
golang-1.24_debug-tools
golang-1.24_dist-tools
golang-1.24_doc-tools
golang-1.24_go-build-src
golang-1.24_go-env
golang-1.24_headers
golang-1.24_internal-src
golang-1.24_libs
golang-1.24_minimal
golang-1.24_profiling-tools
golang-1.24_runtime-src
golang-1.24_src-with-tests
golang-1.24_symlinks
golang-1.24_testing-tools
golang-1.24_time-src
golang-1.24-go: 🌂 45.83% (13 missing) 
golang-1.24-go_api
golang-1.24-go_bash-scripts
golang-1.24-go_bins
golang-1.24-go_cgo-support
golang-1.24-go_cmd-src
golang-1.24-go_core
golang-1.24-go_go-build-src
golang-1.24-go_go-env
golang-1.24-go_internal-src
golang-1.24-go_libs
golang-1.24-go_runtime-src
golang-1.24-go_src-with-tests
golang-1.24-go_time-src
golang-1.24-src: 🌂 20.83% (19 missing) 
golang-1.24-src_bins
golang-1.24-src_build-tools
golang-1.24-src_cgo-support
golang-1.24-src_cgo-tools
golang-1.24-src_cmd-src
golang-1.24-src_core
golang-1.24-src_debug-tools
golang-1.24-src_dist-tools
golang-1.24-src_doc-tools
golang-1.24-src_go-build-src
golang-1.24-src_go-env
golang-1.24-src_headers
golang-1.24-src_internal-src
golang-1.24-src_minimal
golang-1.24-src_profiling-tools
golang-1.24-src_runtime-src
golang-1.24-src_symlinks
golang-1.24-src_testing-tools
golang-1.24-src_time-src
golang-go: 🌂 0.00% (24 missing) 
golang-go_api
golang-go_bash-scripts
golang-go_bins
golang-go_build-tools
golang-go_cgo-support
golang-go_cgo-tools
golang-go_cmd-src
golang-go_copyright
golang-go_core
golang-go_debug-tools
golang-go_dist-tools
golang-go_doc-tools
golang-go_go-build-src
golang-go_go-env
golang-go_headers
golang-go_internal-src
golang-go_libs
golang-go_minimal
golang-go_profiling-tools
golang-go_runtime-src
golang-go_src-with-tests
golang-go_symlinks
golang-go_testing-tools
golang-go_time-src
golang-src: 🌂 0.00% (24 missing) 
golang-src_api
golang-src_bash-scripts
golang-src_bins
golang-src_build-tools
golang-src_cgo-support
golang-src_cgo-tools
golang-src_cmd-src
golang-src_copyright
golang-src_core
golang-src_debug-tools
golang-src_dist-tools
golang-src_doc-tools
golang-src_go-build-src
golang-src_go-env
golang-src_headers
golang-src_internal-src
golang-src_libs
golang-src_minimal
golang-src_profiling-tools
golang-src_runtime-src
golang-src_src-with-tests
golang-src_symlinks
golang-src_testing-tools
golang-src_time-src
make: 🌂 4.17% (23 missing) 
make_api
make_bash-scripts
make_build-tools
make_cgo-support
make_cgo-tools
make_cmd-src
make_copyright
make_core
make_debug-tools
make_dist-tools
make_doc-tools
make_go-build-src
make_go-env
make_headers
make_internal-src
make_libs
make_minimal
make_profiling-tools
make_runtime-src
make_src-with-tests
make_symlinks
make_testing-tools
make_time-src

Arch: x86_64

Coverage: 10.12%

golang: 🌂 0.00% (24 missing) 
golang_api
golang_bash-scripts
golang_bins
golang_build-tools
golang_cgo-support
golang_cgo-tools
golang_cmd-src
golang_copyright
golang_core
golang_debug-tools
golang_dist-tools
golang_doc-tools
golang_go-build-src
golang_go-env
golang_headers
golang_internal-src
golang_libs
golang_minimal
golang_profiling-tools
golang_runtime-src
golang_src-with-tests
golang_symlinks
golang_testing-tools
golang_time-src
golang-1.24: 🌂 0.00% (24 missing) 
golang-1.24_api
golang-1.24_bash-scripts
golang-1.24_bins
golang-1.24_build-tools
golang-1.24_cgo-support
golang-1.24_cgo-tools
golang-1.24_cmd-src
golang-1.24_copyright
golang-1.24_core
golang-1.24_debug-tools
golang-1.24_dist-tools
golang-1.24_doc-tools
golang-1.24_go-build-src
golang-1.24_go-env
golang-1.24_headers
golang-1.24_internal-src
golang-1.24_libs
golang-1.24_minimal
golang-1.24_profiling-tools
golang-1.24_runtime-src
golang-1.24_src-with-tests
golang-1.24_symlinks
golang-1.24_testing-tools
golang-1.24_time-src
golang-1.24-go: 🌂 45.83% (13 missing) 
golang-1.24-go_api
golang-1.24-go_bash-scripts
golang-1.24-go_bins
golang-1.24-go_cgo-support
golang-1.24-go_cmd-src
golang-1.24-go_core
golang-1.24-go_go-build-src
golang-1.24-go_go-env
golang-1.24-go_internal-src
golang-1.24-go_libs
golang-1.24-go_runtime-src
golang-1.24-go_src-with-tests
golang-1.24-go_time-src
golang-1.24-src: 🌂 20.83% (19 missing) 
golang-1.24-src_bins
golang-1.24-src_build-tools
golang-1.24-src_cgo-support
golang-1.24-src_cgo-tools
golang-1.24-src_cmd-src
golang-1.24-src_core
golang-1.24-src_debug-tools
golang-1.24-src_dist-tools
golang-1.24-src_doc-tools
golang-1.24-src_go-build-src
golang-1.24-src_go-env
golang-1.24-src_headers
golang-1.24-src_internal-src
golang-1.24-src_minimal
golang-1.24-src_profiling-tools
golang-1.24-src_runtime-src
golang-1.24-src_symlinks
golang-1.24-src_testing-tools
golang-1.24-src_time-src
golang-go: 🌂 0.00% (24 missing) 
golang-go_api
golang-go_bash-scripts
golang-go_bins
golang-go_build-tools
golang-go_cgo-support
golang-go_cgo-tools
golang-go_cmd-src
golang-go_copyright
golang-go_core
golang-go_debug-tools
golang-go_dist-tools
golang-go_doc-tools
golang-go_go-build-src
golang-go_go-env
golang-go_headers
golang-go_internal-src
golang-go_libs
golang-go_minimal
golang-go_profiling-tools
golang-go_runtime-src
golang-go_src-with-tests
golang-go_symlinks
golang-go_testing-tools
golang-go_time-src
golang-src: 🌂 0.00% (24 missing) 
golang-src_api
golang-src_bash-scripts
golang-src_bins
golang-src_build-tools
golang-src_cgo-support
golang-src_cgo-tools
golang-src_cmd-src
golang-src_copyright
golang-src_core
golang-src_debug-tools
golang-src_dist-tools
golang-src_doc-tools
golang-src_go-build-src
golang-src_go-env
golang-src_headers
golang-src_internal-src
golang-src_libs
golang-src_minimal
golang-src_profiling-tools
golang-src_runtime-src
golang-src_src-with-tests
golang-src_symlinks
golang-src_testing-tools
golang-src_time-src
make: 🌂 4.17% (23 missing) 
make_api
make_bash-scripts
make_build-tools
make_cgo-support
make_cgo-tools
make_cmd-src
make_copyright
make_core
make_debug-tools
make_dist-tools
make_doc-tools
make_go-build-src
make_go-env
make_headers
make_internal-src
make_libs
make_minimal
make_profiling-tools
make_runtime-src
make_src-with-tests
make_symlinks
make_testing-tools
make_time-src

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lczyk lczyk lczyk approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@lczyk lczyk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhijie-yang @lczyk