Skip to content

Conversation

@advy99
Copy link
Contributor

@advy99 advy99 commented Jan 15, 2025

This PR introduces a new option called "Posting details" with two choices, basic posting and detailed posting. When selecting basic posting, NanoLedger works as for now, and when selecting "Detailed posting", when editing a posting a new row for editing the posting note and status will appear on the selected row:

I also added the necessary parts in the parser to parse the posting status. For now I will set the PR as draft as I still need to write the parser tests.

Fixes #229

@advy99 advy99 marked this pull request as ready for review January 25, 2025 18:45
@advy99 advy99 changed the title Draft: Implement a way to edit postings note and status Implement a way to edit postings note and status Jan 25, 2025
@chvp chvp self-requested a review January 26, 2025 13:00
@chvp chvp added the enhancement New feature or request label Feb 15, 2025
Copy link
Owner

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for letting this sit for so long, I had a really busy february. To be honest, I'm not a huge fan of introducing yet another setting for this. Especially because it's one that I personally won't use. I'd prefer to redesign the posting rows a little bit to make space for an always-present expand button rather than introducing the setting...

@advy99
Copy link
Contributor Author

advy99 commented Apr 9, 2025

Hi! Sorry for the delay. No problem from my part. If you want to keep the changes from the data storage and parsing part, I could modify the PR to delete all the UI and preferences things, just to keep everything else waiting for a UI redesign. On the contrary, if you think that is better to not introduce all this code until the feature is fully ready, feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow edit postings notes

2 participants