Open
Conversation
- Exclude Jersey & Guernsey From UK for tax purposes. Jersey and Gurney are part of the UK but are no part of the European Union for VAT purposes - Update United Kingdom to show it excludes channel islands & add exclude regex for IM/JE postcodes - Add IM postcodes regex
bojanz
reviewed
Oct 23, 2019
| "id": "gb_ci_vat_1", | ||
| "name": "Jersey", | ||
| "country_code": "GB", | ||
| "included_postal_codes": "\/(^JE[0-9]{1})\/" |
Contributor
There was a problem hiding this comment.
Why do we need two zone members for Jersey, with a very similar regexp? Can't we just say "JE + a number, anywhere in the string"?
bojanz
reviewed
Oct 23, 2019
| "id": "gb_ci_vat_3", | ||
| "name": "Guernsey", | ||
| "country_code": "GB", | ||
| "included_postal_codes": "\/(^GY[0-9]{1,2})\/" |
Contributor
|
Thanks! Left a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UK Channel islands should be treated differently in regards to tax, to the test of the UK.
Exclude Jersey & Guernsey From UK for tax purposes. Jersey and Gurney are part of the UK but are no part of the European Union for VAT purposes
Update United Kingdom to show it excludes channel islands & add exclude regex for IM/JE postcodes
Add IM postcodes regex