Skip to content

Split out UK channel islands #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
booni3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Split out UK channel islands #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions resources/tax_type/gb_ci_vat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "British Channel Islands VAT",
"generic_label": "vat",
"display_inclusive": true,
"zone": "gb_ci_vat",
"tag": "EU",
"rates": [
{
"id": "gb_ci_vat_zero",
"name": "Zero",
"default": true,
"amounts": [
{
"id": "gb_ci_vat_zero",
"amount": 0,
"start_date": "1973-01-01"
}
]
}
]
}
34 changes: 34 additions & 0 deletions resources/zone/gb_ci_vat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"name": "United Kingdom - Channel Islands (VAT)",
"scope": "tax",
"members": [
{
"type": "country",
"id": "gb_ci_vat_0",
"name": "Jersey",
"country_code": "JE",
"included_postal_codes": "\/(^$)|(^JE[0-9]{1})\/"
},
{
"type": "country",
"id": "gb_ci_vat_1",
"name": "Jersey",
"country_code": "GB",
"included_postal_codes": "\/(^JE[0-9]{1})\/"
Copy link
Contributor

@bojanz bojanz Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two zone members for Jersey, with a very similar regexp? Can't we just say "JE + a number, anywhere in the string"?

},
{
"type": "country",
"id": "gb_ci_vat_2",
"name": "Guernsey",
"country_code": "GG",
"included_postal_codes": "\/(^$)|(^GY[0-9]{1,2})\/"
},
{
"type": "country",
"id": "gb_ci_vat_3",
"name": "Guernsey",
"country_code": "GB",
"included_postal_codes": "\/(^GY[0-9]{1,2})\/"
Copy link
Contributor

@bojanz bojanz Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

}
]
}
8 changes: 5 additions & 3 deletions resources/zone/gb_vat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@
{
"type": "country",
"id": "gb_vat_0",
"name": "United Kingdom",
"country_code": "GB"
"name": "United Kingdom (ex. Channel Islands & Isle Of Man)",
"country_code": "GB",
"excluded_postal_codes": "\/(^IM[0-9]{1})|(^JE[0-9]{1})|(^GY[0-9]{1,2})\/"
},
{
"type": "country",
"id": "gb_vat_1",
"name": "Isle of Man",
"country_code": "IM"
"country_code": "IM",
"included_postal_codes": "\/^IM[0-9]{1}\/"
}
]
}