Maximum likelihood method for polarization#443
Open
eneights wants to merge 12 commits intocositools:developfrom
Open
Maximum likelihood method for polarization#443eneights wants to merge 12 commits intocositools:developfrom
eneights wants to merge 12 commits intocositools:developfrom
Conversation
Contributor
Author
|
This is ready to be looked at, but I have only tested it with the one GRB in the example notebook so far, and the fraction it outputs is not correct. This might just be due to the coarse response, but before merging, it should probably be tested on some DC3 GRBs |
Collaborator
|
Cool! @eneights Can you please share an executed tutorial (with outputs) to first see if we can reproduce your results? |
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
@israelmcmc Yes, just added it! |
Collaborator
|
Thanks, @eneights ! Is the PD 0-100 or is it part of the issue your are fixing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates COSILike to enable polarization fitting in the CDS, and fixes a mistake with the polarization handling in the point source response.
This replaces PR #367. I'm opening this as a draft PR for now, since I still need to add an example notebook and add/fix unit tests.