Maximum likelihood polarization fitting#367
Closed
eneights wants to merge 32 commits intocositools:developfrom
Closed
Maximum likelihood polarization fitting#367eneights wants to merge 32 commits intocositools:developfrom
eneights wants to merge 32 commits intocositools:developfrom
Conversation
…me polarization expectation
8 tasks
8 tasks
israelmcmc
added
Feature / Enhancement
Contributor
Author
|
Replaced by PR #443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes updates to COSILike to allow for polarization to be fit using 3ML, as well as an example notebook which performs the fit in both the spacecraft and inertial frames. The fit currently either converges to incorrect values, or not at all. I still need to test this more to determine where the issue is coming from.
Closes #211