Skip to content

feat: add CRB_OWNER_LOGINS env var for triage owner detection#223

Merged
ichoosetoaccept merged 1 commit intomainfrom
03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection
Mar 12, 2026
Merged

feat: add CRB_OWNER_LOGINS env var for triage owner detection#223
ichoosetoaccept merged 1 commit intomainfrom
03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection

Conversation

@ichoosetoaccept
Copy link
Member

@ichoosetoaccept ichoosetoaccept commented Mar 12, 2026

Closes ISM-326

Replaces the hardcoded ["ichoosetoaccept"] fallback in triage_review_comments with a configurable CRB_OWNER_LOGINS env var.

Changes:

  • Add owner_logins: list[str] to Config / _EnvConfig (defaults to empty list)
  • triage_review_comments reads get_config().owner_logins when no explicit param passed
  • Add CRB_OWNER_LOGINS to _KNOWN_ENV_PREFIXES in cli.py
  • Tests for config loading, env var parsing, and config-based triage filtering

Usage in MCP client config:

{"CRB_OWNER_LOGINS": "[\"ichoosetoaccept\", \"mybot\"]"}

Copy link
Member Author

ichoosetoaccept commented Mar 12, 2026

@linear
Copy link

linear bot commented Mar 12, 2026

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

Open in Devin Review

@ichoosetoaccept ichoosetoaccept force-pushed the 03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection branch from f8c12c6 to 8bbccf5 Compare March 12, 2026 10:03
@ichoosetoaccept ichoosetoaccept force-pushed the 03-12-chore-add-byterover-context-tree-and-gitignore-config branch from 822e735 to 307ff81 Compare March 12, 2026 10:03
@ichoosetoaccept ichoosetoaccept changed the base branch from 03-12-chore-add-byterover-context-tree-and-gitignore-config to graphite-base/223 March 12, 2026 10:04
@ichoosetoaccept ichoosetoaccept force-pushed the 03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection branch from 8bbccf5 to 4cf547a Compare March 12, 2026 10:05
@graphite-app graphite-app bot changed the base branch from graphite-base/223 to main March 12, 2026 10:05
@ichoosetoaccept ichoosetoaccept force-pushed the 03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection branch from 4cf547a to e83f16b Compare March 12, 2026 10:05
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

@ichoosetoaccept ichoosetoaccept merged commit 08e8e20 into main Mar 12, 2026
11 checks passed
@ichoosetoaccept ichoosetoaccept deleted the 03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection branch March 12, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant