feat: size-based log rotation for diagnostic JSONL files#224
Merged
ichoosetoaccept merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Replace line-count truncation with size-based rotation (2MB × 7 backups). Shared rotate_if_needed() in log_rotation.py wired into all three log writers (gh.py, github_api.py, middleware.py, io_tap.py). Adds stale PID file cleanup on server startup. Closes ISM-332
This was referenced Mar 12, 2026
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ichoosetoaccept
force-pushed
the
03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection
branch
2 times, most recently
from
4cf547a to
e83f16b
Compare
ichoosetoaccept
force-pushed
the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
from
e095bbb to
2c905f6
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ichoosetoaccept
force-pushed
the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
2 times, most recently
from
68ddde0 to
3be5f75
Compare
ichoosetoaccept
changed the base branch from
03-12-feat-add-crb_owner_logins-env-var-for-triage-owner-detection
to
graphite-base/224
ichoosetoaccept
force-pushed
the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
from
3be5f75 to
46db8b2
Compare
ichoosetoaccept
force-pushed
the
graphite-base/224
branch
from
e83f16b to
08e8e20
Compare
ichoosetoaccept
force-pushed
the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
from
46db8b2 to
13ed4b7
Compare
This comment has been minimized.
This comment has been minimized.
ichoosetoaccept
force-pushed
the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
from
13ed4b7 to
46b487a
Compare
ichoosetoaccept
deleted the
03-12-feat-size-based-log-rotation-for-diagnostic-jsonl-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace line-count truncation with size-based rotation (2MB × 7 backups). Shared rotate_if_needed() in log_rotation.py wired into all three log writers (gh.py, github_api.py, middleware.py, io_tap.py). Adds stale PID file cleanup on server startup.
Closes ISM-327
Closes ISM-XXX