Skip to content

Conversation

@itsalfredakku
Copy link
Member

This pull request adds a check to ensure the ANDROID_NDK_HOME environment variable is set before proceeding with the Android build process. If the variable is not set, the script logs an error and exits early. This helps prevent build failures due to missing dependencies.

  • Build environment validation:
    • scripts/build-android.sh: Added a check to verify that ANDROID_NDK_HOME is set, logging an error and exiting if it is not.

Copilot AI review requested due to automatic review settings January 11, 2026 07:16
@itsalfredakku itsalfredakku merged commit 346b935 into master Jan 11, 2026
20 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds validation to check that the ANDROID_NDK_HOME environment variable is set before proceeding with the Android build process in the build_android_auto function. This helps prevent build failures by detecting missing configuration early.

Changes:

  • Added environment variable validation in build_android_auto function to verify ANDROID_NDK_HOME is set before detecting device architecture and building

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +232 to +235
if [ -z "$ANDROID_NDK_HOME" ]; then
log_error "ANDROID_NDK_HOME not set"
exit 1
fi
Copy link

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message for missing ANDROID_NDK_HOME is inconsistent with other similar checks in the script. The build_android() function (lines 91-96) provides helpful context including example paths for setting the variable. This check should include the same helpful information to maintain consistency and provide a better user experience.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants