Skip to content

refactor: Add error handling for missing ANDROID_NDK_HOME in build_android_auto function #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsalfredakku merged 1 commit into from
Jan 11, 2026
Merged

refactor: Add error handling for missing ANDROID_NDK_HOME in build_android_auto function #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/build-android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,11 @@ build_android_armv7() {
build_android_auto() {
log_info "Detecting connected device architecture..."

if [ -z "$ANDROID_NDK_HOME" ]; then
log_error "ANDROID_NDK_HOME not set"
exit 1
fi
Comment on lines +232 to +235
Copy link

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message for missing ANDROID_NDK_HOME is inconsistent with other similar checks in the script. The build_android() function (lines 91-96) provides helpful context including example paths for setting the variable. This check should include the same helpful information to maintain consistency and provide a better user experience.

Copilot uses AI. Check for mistakes.

if ! command -v adb &> /dev/null; then
log_error "adb not found. Install Android SDK platform-tools."
exit 1
Expand Down