Draft
Conversation
Dreamsorcerer
commented
Feb 25, 2026
| setattr(cls, name, None) | ||
|
|
||
| def __init__(self, *args, **kwargs) -> None: # type: ignore[no-untyped-def] | ||
| def __init__(self, global_config: GlobalConfig = global_config, **kwargs: Any): |
Collaborator
Author
There was a problem hiding this comment.
As an alternative to asking subclasses (that need a custom __init__()) to include global_config here, I could move it into the ModuleConfig itself? Then subclasses will just pass kwargs alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Working towards #1082, this helps standardise setting in modules which can then be expanded upon to enable further things such as CLI arguments to be injected.
Solution
Primary change to developers is that the
__init__()method now uses a fixed signature and all configurable options appear in the config. That config is now a pydantic model, so it gets verified when the module is instantiated.A lot of typing fixes were also made by changing incorrect references to Module to ModuleBase.
Breaking Changes
Subclasses of Module must now match the
__init__()signature of the Module class.