Skip to content

Fix deprecation message for rotation volume #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreyas-flex wants to merge 15 commits into
base: main
Choose a base branch
from
+4 −2
Open

Fix deprecation message for rotation volume #1784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eb1782a
add sphere entity
shreyas-flex Feb 2, 2026
7ae247d
addressing bugbot comment
shreyas-flex Feb 2, 2026
5a055f2
more bugbot comments
shreyas-flex Feb 2, 2026
887c069
add translator support
shreyas-flex Feb 2, 2026
47dff41
make all three spacings optional, construction validated for Axisymme…
shreyas-flex Feb 2, 2026
59fea8a
formatting
shreyas-flex Feb 2, 2026
294bd48
resolve PR comments
shreyas-flex Feb 4, 2026
47ce4a3
Merge branch 'main' into shreyas/sphere-entity
shreyas-flex Feb 4, 2026
e9ab6d8
format
shreyas-flex Feb 4, 2026
88e7487
resolve bugbot comment
shreyas-flex Feb 4, 2026
ef21e4e
Merge branch 'main' into shreyas/sphere-entity
benflexcompute Feb 5, 2026
f8da43d
update error message
shreyas-flex Feb 10, 2026
d11e036
update msg
shreyas-flex Feb 10, 2026
8e3decd
Merge remote-tracking branch 'origin/main' into shreyas/fix-deprecati…
shreyas-flex Feb 10, 2026
3df0c3f
Merge branch 'main' into shreyas/fix-deprecation-message-for-rotation…
benflexcompute Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flow360/component/simulation/meshing_param/volume_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def _validate_spacing_requirements_by_entity_type(self, param_info: ParamsValida

@deprecated(
"The `RotationCylinder` class is deprecated! Use `RotationVolume`,"
"which supports both `Cylinder` and `AxisymmetricBody` entities instead."
"which supports `Cylinder`, `AxisymmetricBody`, and `Sphere` entities instead."
)
class RotationCylinder(RotationVolume):
"""
Expand Down
4 changes: 3 additions & 1 deletion flow360/component/simulation/translator/volume_meshing_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def uniform_refinement_translator(obj: UniformRefinement):
return {"spacing": obj.spacing.value.item()}


def cylindrical_refinement_translator(obj: Union[AxisymmetricRefinement, RotationVolume]):
def cylindrical_refinement_translator(
obj: Union[AxisymmetricRefinement, RotationVolume],
):
"""
Translate AxisymmetricRefinement or RotationVolume with Cylinder/AxisymmetricBody entities.

Expand Down
Loading