fix(): Fix edge_split_layers implicit-default warning noise #1799
+172
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, targeted change to pre-validation/upload serialization that only drops a single implicit field; behavior is covered by unit tests.
Overview
Suppresses warning noise caused by an implicitly injected
meshing.defaults.edge_split_layersdefault during serialization.Adds
strip_implicit_edge_split_layers_inplace()and applies it before both local validation (validate_params_with_context) and draft upload (Draft.update_simulation_params), while preservingedge_split_layerswhen the user explicitly set it. Includes tests covering implicit vs explicit behavior and verifying the uploaded payload omits only the implicit field.Written by Cursor Bugbot for commit 1456023. This will update automatically on new commits. Configure here.