Skip to content

Conversation

@benflexcompute
Copy link
Collaborator

@benflexcompute benflexcompute commented Feb 11, 2026

Note

Low Risk
Small, targeted change to pre-validation/upload serialization that only drops a single implicit field; behavior is covered by unit tests.

Overview
Suppresses warning noise caused by an implicitly injected meshing.defaults.edge_split_layers default during serialization.

Adds strip_implicit_edge_split_layers_inplace() and applies it before both local validation (validate_params_with_context) and draft upload (Draft.update_simulation_params), while preserving edge_split_layers when the user explicitly set it. Includes tests covering implicit vs explicit behavior and verifying the uploaded payload omits only the implicit field.

Written by Cursor Bugbot for commit 1456023. This will update automatically on new commits. Configure here.

@benflexcompute benflexcompute changed the title Fix edge_split_layers implicit-default warning noise fix(): Fix edge_split_layers implicit-default warning noise Feb 11, 2026
@benflexcompute benflexcompute merged commit f495588 into release-candidate/25.8 Feb 11, 2026
19 checks passed
@benflexcompute benflexcompute deleted the fix/edge-split-layers-implicit-warning branch February 11, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant