Fix/separate union for S2 message elements#98
Merged
Conversation
…t classes Signed-off-by: F.N. Claessen <felix@seita.nl>
…ent type Signed-off-by: F.N. Claessen <felix@seita.nl>
…rate-union-for-S2MessageElements Signed-off-by: F.N. Claessen <felix@seita.nl> # Conflicts: # src/s2python/message.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Merged
Signed-off-by: F.N. Claessen <felix@seita.nl>
…me about a style issue, ugh Signed-off-by: F.N. Claessen <felix@seita.nl>
Collaborator
Author
|
@VladIftime Could you please help me find out why the pipeline is still failing? |
Collaborator
Author
|
@jorritn do you think |
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Contributor
Yes, I think it is. An alternative could be to use |
Contributor
|
One other thing that I would like to point out is that the |
Signed-off-by: F.N. Claessen <felix@seita.nl>
This reverts commit 01829a1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message_idare typed ass2_python.message.S2Message.s2_python.message.S2MessageElement.