Merged
Conversation
Member
|
I think we should accompany this PR with an upstream PR to gomodules/envsubst to add the feature of drone/envsubst#34 so that we can remove this fork from our repo once gomodules/envsubst has been released with the feature. |
Member
Author
|
@makkes we can't do that, |
Member
Ah, I understand. So this is meant to be a permanent fork. 👍🏻 |
makkes
approved these changes
Apr 8, 2024
Forked from https://github.com/drone/envsubst Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Incorporate drone/envsubst#34 Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a fork of https://github.com/gomodules/envsubst and incorporates drone/envsubst#34.
This permanent fork is needed because envsubst powers a GA feature of Flux, and the Drone's project looks like is no longer maintained.
xref: fluxcd/flux2#4694