Skip to content

Conversation

@yoursdearboy
Copy link

Closes #1111

What has been done to verify that this works as intended?

Successfully started PostgreSQL container with docker-compose.dev.yml (make dev) and run migrations (cd server && make)

Why is this the best possible solution? Were any other approaches considered?

It synchronizes credentials across docker and server configs. Another approach would be to change credentials in server config or guide developers to change them manually.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Doesn't affect users.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn
Copy link
Contributor

alxndrsn commented Feb 9, 2026

@sadiqkhoja this change makes sense to me; does it fit with your use of make dev?

@sadiqkhoja
Copy link
Contributor

The change looks good to me. But I would prefer backend code to be changed to have odk as dbname, username and password. jubilant is reminiscence of the past when the team had no name for the Central.

@alxndrsn
Copy link
Contributor

The change looks good to me. But I would prefer backend code to be changed to have odk as dbname, username and password. jubilant is reminiscence of the past when the team had no name for the Central.

I think moving away from jubilant is a larger question. I'm approving this PR as I think it's helpful to standardise with the dev environment supplied in the repo at https://github.com/getodk/central-backend. @sadiqkhoja please approve/merge if you agree.

@alxndrsn alxndrsn self-requested a review February 10, 2026 16:15
Copy link
Contributor

@alxndrsn alxndrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardising with https://github.com/getodk/central-backend/blob/master/config/default.json and reducing manual steps in dev environment setup is very helpful IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants