Implement an alternate way to calculate normalized percentile scores #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's been decided to move forward with this way to calculate normalized percentiles. |
…centiles_length_agnostic
ldhtnp
approved these changes
Jan 6, 2026
Contributor
ldhtnp
left a comment
ldhtnp
left a comment
There was a problem hiding this comment.
+1
Changes look good to me!
susannasiebert
force-pushed
the
7.0.0_normalized_percentiles_length_agnostic
branch
from
5cc8a86 to
090d4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first implementation, the scores were being calculate on a per-length basis. This update calculates them in a length-agnostic way. The update was implemented via new parameter to the
calculate_normalized_percentilemethod. This will allow us to run the normalized percentile calculation either way. The parameter can be exposed to our users in the run commands, if so desired.It's still to be determined, which way is preferable.