Skip to content

chore: support new architecture#84

Open
MounirDhahri wants to merge 10 commits intoiamolegga:masterfrom
MounirDhahri:chore/migrate-to-new-architecture
Open

chore: support new architecture#84
MounirDhahri wants to merge 10 commits intoiamolegga:masterfrom
MounirDhahri:chore/migrate-to-new-architecture

Conversation

@MounirDhahri
Copy link

@MounirDhahri MounirDhahri commented Aug 20, 2025

First, thanks for the package. It's very useful

In this PR, I am making the following changes:

  • Add new architecture support
  • Modernize the example app
    • Because the app was using bare react-native, it was very time-consuming to upgrade with very little value compared to the time it takes and it doesn't make sense to spend time maintaining it. So I adjusted it to be instead using expo with prebuild to make it easier in the future to make upgrades. I used upgrading-expo with Claude to make the upgrade.
  • Add CI e2e tests. Because the package is open source, it should be possible to take advantage of Github CI free tier. E2E are often flaky in react-native so 🤞🏽

@RohovDmytro
Copy link

Can we release this?..

@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch 2 times, most recently from 4235bb3 to b5fb3dd Compare December 8, 2025 17:16
@phazei
Copy link

phazei commented Feb 10, 2026

@iamolegga ?

This is becoming essential

#36

@iamolegga
Copy link
Owner

@phazei

image

@MounirDhahri MounirDhahri marked this pull request as ready for review February 11, 2026 08:15
@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch 2 times, most recently from e68fb1d to b407d59 Compare February 11, 2026 08:30
@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch from b407d59 to e077a0f Compare February 11, 2026 08:30
@phazei
Copy link

phazei commented Feb 12, 2026

@iamolegga

Screenshot 2026-02-11 at 5 35 06 PM

😄

Thanks @MounirDhahri

@iamolegga
Copy link
Owner

Good, thank you everyone, now before merging I need some time to spend on tests for checking that after migration everything will work as before

@MounirDhahri
Copy link
Author

thank you @iamolegga for your help already. I have some time today and will try to help by upgrading the example app and updating some dependencies and make the tests pass

@iamolegga
Copy link
Owner

thanks @MounirDhahri
my original idea was to have tests before merging this PR and then check the transition with your code on top of it
please give a week I hope I will find time to solve this 🙏

@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch 3 times, most recently from 868f0fb to 00a7145 Compare February 13, 2026 11:29
@MounirDhahri
Copy link
Author

MounirDhahri commented Feb 13, 2026

Sure, please take as much time as you need.
I am not blocked by this because I am using my own fork here https://github.com/MounirDhahri/react-native-launch-arguments.

Because this package has been useful for us + you mentioned earlier that you want to test builds manually, I had the idea to run the tests in Github Actions to make it easier for you. Example (MounirDhahri#1)

Edit: tests are running now ios and android

@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch from 00a7145 to 4941ffc Compare February 13, 2026 13:12
@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch from aa50158 to 14bf934 Compare February 13, 2026 13:40
@MounirDhahri MounirDhahri force-pushed the chore/migrate-to-new-architecture branch from 6a394c3 to a69792e Compare February 13, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants