Skip to content

Comments

Send chat notifications also when build becomes fixed or is unstable#11

Open
markahon wants to merge 7 commits intojenkinsci:masterfrom
markahon:master
Open

Send chat notifications also when build becomes fixed or is unstable#11
markahon wants to merge 7 commits intojenkinsci:masterfrom
markahon:master

Conversation

@markahon
Copy link

I would assume most people would like to see some notification when build is fixed or unstable. This is how email notifications are usually configured.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@anttipitkanen
Copy link

Sorry for the delay in getting back to you!

This seems like a good addition to the plugin. Could the different build statuses be separate options in the notification configuration? I.e. something like

Send chat notification on 
[ ] failure 
[ ] unstable 
[ ] fixed

Here the failure check box would map to the existing value from field chatNotification (the naming isn't optimal) and the others would be new configuration fields. I would prefer that since it doesn't change the plugin behavior for existing users, but allows them to opt-in. Does that sound reasonable?

@markahon
Copy link
Author

That sounds reasonable. Unfortunately I don't have an environment to test the plugin at the moment since I've moved on to other things. I could implement the change, but I'd rather not do it blindfolded.

@Suirtimed
Copy link

My team just asked for this same kind of chat notification rather than just the flow notifications. We're also using the Build Pipeline Plugin and they would like targeted notifications in chat with @user when the source job was triggered by a user or a github.com event that passes the information along... @markahon I'd be willing to test the plugin if that would help.

@anttipitkanen
Copy link

@Suirtimed highlighting the person behind the build sounds like a nice feature. For it to work seamlessly, the plugin would have to know how the Jenkins / Github users map to Flowdock users so that the highlight in chat message matches the user's nick in Flowdock.

@unrealsolver
Copy link

+1 for it. Does anyone tested it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants