Skip to content

Send chat notifications also when build becomes fixed or is unstable #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markahon wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Send chat notifications also when build becomes fixed or is unstable #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70f1545
send notification also when build is fixed or becomes unstable
markahon Jan 28, 2015
520fb97
converted tabs to spaces
markahon Jan 28, 2015
5df10b6
display ... ' still' in notification message if build result is same …
markahon Jan 28, 2015
02e0945
make notification status stand out from message flow
markahon Jan 28, 2015
543fcfb
make readily built plugin .hpi available
markahon Jan 28, 2015
794fd06
added space between notification icon and text
markahon Jan 28, 2015
3286ceb
update package
markahon Jan 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added dist/jenkins-flowdock-plugin.hpi
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions src/main/java/com/flowdock/jenkins/ChatMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ public static ChatMessage fromBuild(AbstractBuild build, BuildResult buildResult
String buildNo = build.getDisplayName().replaceAll("#", "");
content.append(projectName + configuration).append(" build ").append(buildNo);
content.append(" ").append(buildResult.getHumanResult());
if (build.getResult() == build.getPreviousBuild().getResult()) {
content.append(" still");
}
content.append(".");

String rootUrl = Hudson.getInstance().getRootUrl();
String buildLink = (rootUrl == null) ? null : rootUrl + build.getUrl();
Expand Down
28 changes: 23 additions & 5 deletions src/main/java/com/flowdock/jenkins/FlowdockNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,29 @@ protected void notifyFlowdock(AbstractBuild build, BuildResult buildResult, Buil
api.pushTeamInboxMessage(msg);
listener.getLogger().println("Flowdock: Team Inbox notification sent successfully");

if(build.getResult() != Result.SUCCESS && chatNotification) {
ChatMessage chatMsg = ChatMessage.fromBuild(build, buildResult, listener);
chatMsg.setTags(vars.expand(notificationTags));
api.pushChatMessage(chatMsg);
logger.println("Flowdock: Chat notification sent successfully");
if (chatNotification) {
String importanceIcon = null;
switch (buildResult) {
case FAILURE:
importanceIcon = ":exclamation:";
break;
case FIXED:
importanceIcon = ":white_check_mark:";
break;
case UNSTABLE:
importanceIcon = ":grey_exclamation:";
break;
default:
break;
}

if (importanceIcon != null) {
ChatMessage chatMsg = ChatMessage.fromBuild(build, buildResult, listener);
chatMsg.setTags(vars.expand(notificationTags));
chatMsg.setContent(importanceIcon + " " + chatMsg.content);
api.pushChatMessage(chatMsg);
logger.println("Flowdock: Chat notification sent successfully");
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/com/flowdock/jenkins/FlowdockNotifier/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
title="Test connection with Chat notification" progress="Sending..."
method="testConnection" with="flowToken,notificationTags" />

<f:entry title="Chat notification when build fails" field="chatNotification">
<f:entry title="Chat notification when build fails, becomes instable or returns to stable" field="chatNotification">
<f:checkbox />
</f:entry>

Expand Down