Skip to content

WIP: Swapping mysql for percona #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Leopere wants to merge 1 commit into from
Closed

WIP: Swapping mysql for percona #69

Leopere wants to merge 1 commit into from

Conversation

@Leopere
Copy link
Collaborator

@Leopere Leopere commented Apr 30, 2019

Completely untested but stored for now in case we want to start reviewing this.

@Leopere Leopere added type: improvement Existing (or partially existing) functionality needs to be changed help wanted Extra attention is needed type: testing Solution needs additional user testing type: refactor Minimal user-visible changes, but significant internal work priority: medium Work needs to be done within 2-3 sprints labels Apr 30, 2019
@Leopere Leopere self-assigned this Apr 30, 2019
@Leopere Leopere requested a review from EnigmaCurry April 30, 2019 15:03
@lbry-bot lbry-bot assigned EnigmaCurry and unassigned Leopere Apr 30, 2019
@Leopere Leopere added this to the Needs milestone Apr 30, 2019
This was referenced Apr 30, 2019
Closed
Closed
@Leopere Leopere added priority: low Work should be done but can stay in the backlog for now and removed priority: medium Work needs to be done within 2-3 sprints labels Apr 30, 2019
@EnigmaCurry
Copy link
Collaborator

EnigmaCurry commented Apr 30, 2019

#71 is using this same percona image and is currently ingesting data, I will let it go for awhile and see how it performs.

@Leopere
Copy link
Collaborator Author

Leopere commented May 3, 2019 •
edited
Loading

@EnigmaCurry is this still a WIP? From my reading, Percona should be a drop-in replacement for mariadb and mysql.

@EnigmaCurry
Copy link
Collaborator

EnigmaCurry commented May 3, 2019

Percona itself (this image) is working fine (identically to MySQL afaict) so I don't see a problem with merging this.

However, I did end up removing percona from #71 because the helm chart for percona is not as well fleshed out as the MySQL one.

@Leopere
Copy link
Collaborator Author

Leopere commented May 4, 2019

@EnigmaCurry how about instead of redoing the prod-example docker-compose file we add a new example and call this one merge-able. Perhaps mention it in the README.md as another possible option.

@Leopere
Copy link
Collaborator Author

Leopere commented Jun 14, 2019

I'm going to consider this not necessary and abandon it for now based off of feedback from lbry staff.

@Leopere Leopere closed this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnigmaCurry EnigmaCurry EnigmaCurry approved these changes

Assignees

@Leopere Leopere

Labels

help wanted Extra attention is needed priority: low Work should be done but can stay in the backlog for now type: improvement Existing (or partially existing) functionality needs to be changed type: refactor Minimal user-visible changes, but significant internal work type: testing Solution needs additional user testing

Projects

None yet

Milestone

Needs

Development

Successfully merging this pull request may close these issues.

3 participants

@Leopere @EnigmaCurry