Conversions between CoreGraphics and Kurbo types#450
Conversions between CoreGraphics and Kurbo types#450waywardmonkeys wants to merge 1 commit intolinebender:mainfrom
Conversation
|
This is most usable when it is able to use This is still missing support for various types. It might be that the features should change so that they're |
This is an optional feature, not enabled by default.
7308e25 to
345fa2a
Compare
|
@xStrom What might be the best way to handle a feature that only works on a subset of platforms? |
There was a problem hiding this comment.
To solve this at the CI level we would have to use cargo-hack for everything, including testing. However, I think we should solve this at a different level because being able to use --all-features locally for development is very nice.
What I think we should do is make this feature a NOP on other platforms. Then --all-features will continue working and no changes will be needed to CI either.
| [dependencies.objc2-core-foundation] | ||
| version = "0.3.1" | ||
| optional = true | ||
| default-features = false | ||
| features = ["CFCGTypes"] | ||
|
|
||
| [dependencies.objc2-core-graphics] | ||
| version = "0.3.1" | ||
| optional = true | ||
| default-features = false | ||
| features = ["CGPath"] |
There was a problem hiding this comment.
| [dependencies.objc2-core-foundation] | |
| version = "0.3.1" | |
| optional = true | |
| default-features = false | |
| features = ["CFCGTypes"] | |
| [dependencies.objc2-core-graphics] | |
| version = "0.3.1" | |
| optional = true | |
| default-features = false | |
| features = ["CGPath"] | |
| [target.'cfg(target_vendor = "apple")'.dependencies.objc2-core-foundation] | |
| version = "0.3.1" | |
| optional = true | |
| default-features = false | |
| features = ["CFCGTypes"] | |
| [target.'cfg(target_vendor = "apple")'.dependencies.objc2-core-graphics] | |
| version = "0.3.1" | |
| optional = true | |
| default-features = false | |
| features = ["CGPath"] |
| #[cfg(feature = "objc2-core-graphics")] | ||
| mod interop_objc2_core_graphics; |
There was a problem hiding this comment.
| #[cfg(feature = "objc2-core-graphics")] | |
| mod interop_objc2_core_graphics; | |
| #[cfg(all(target_vendor = "apple", feature = "objc2-core-graphics"))] | |
| mod interop_objc2_core_graphics; |
Inspired after #450 We could use those in servo and blitz. Theoretically they could also live in euclid, but given higher number of breaking releases in kurbo, kurbo seems better place for this. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Inspired after linebender/kurbo#450 We could use those in servo and blitz. Theoretically they could also live in euclid, but given higher number of breaking releases in kurbo, kurbo seems better place for this. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This is an optional feature, not enabled by default.