prevent false failure if session state failCondition is undefined#92
Open
lwittle wants to merge 1 commit intolinkedin:masterfrom
Open
prevent false failure if session state failCondition is undefined#92lwittle wants to merge 1 commit intolinkedin:masterfrom
lwittle wants to merge 1 commit intolinkedin:masterfrom
Conversation
Specifically, prevent early session failure in the case that the session key value is blank and the session fail condition is undefined. This will allow the session to continue polling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear DIL maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
ms.session.key.fieldin order to preventisSessionStateFailed()from unexpectedly returning true, due to the empty string matching the empty string. This allows the session to continue polling rather than ending after 1 attempt. This case can apply where the session key is the list filenames output (e.g. status check before 2-step file download pattern).Tests
Commits