Skip to content

prevent false failure if session state failCondition is undefined #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwittle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prevent false failure if session state failCondition is undefined #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cdi-core/src/main/java/com/linkedin/cdi/extractor/MultistageExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,14 +723,14 @@ protected boolean isSessionStateMatch() {
}

/**
* Check if session state is enabled and session fail condition is met
* Check if session state is enabled with a session fail condition defined, and the fail condition is met
*
* @return true if session state is enabled and session fail condition is met
* @return true if session state is enabled with a session fail condition defined, and the fail condition is met
* otherwise return false
*/
protected boolean isSessionStateFailed() {
return jobKeys.isSessionStateEnabled() && extractorKeys.getSessionKeyValue()
.matches(jobKeys.getSessionStateFailCondition());
return jobKeys.isSessionStateEnabled() && StringUtils.isNotBlank(jobKeys.getSessionStateFailCondition())
&& extractorKeys.getSessionKeyValue().matches(jobKeys.getSessionStateFailCondition());
}

/**
Expand Down