Fix filter scoping for Home Screen Sections queries#121
Closed
EclipseKnight wants to merge 1 commit intolostb1t:mainfrom
Closed
Fix filter scoping for Home Screen Sections queries#121EclipseKnight wants to merge 1 commit intolostb1t:mainfrom
EclipseKnight wants to merge 1 commit intolostb1t:mainfrom
Conversation
Author
|
Closing this in favor of #122, which consolidates the filter scope fix and the Home Screen Sections listing-action update in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tracked this to the filter guard in
GelatoItemRepository.ApplyFilters.This regression appears tied to commit
1cb8d57(refactor: filter out streams on everything except single item queries), which changed the guard to rely onIsSingleItemList().The old check used
!ctx.IsSingleItemList(), andIsSingleItemList()depends on this block inCommon.cs:Home Screen Sections does not use
idsfor these calls, so those requests were treated like normal listings and got over-filtered, which resulted in slow loading and timeouts.I changed the guard to
ctx.IsApiListing()and addedisSingleItemQuery = filter.ItemIds is { Length: 1 }. Filters now apply only whenctx.IsApiListing() && !isSingleItemQuery.This keeps listing filters on real listing endpoints and fixes Home Screen Sections latest rows loading correctly.