Fix listing filter scope + Home Screen Sections duplicates#122
Open
EclipseKnight wants to merge 2 commits intolostb1t:mainfrom
Open
Fix listing filter scope + Home Screen Sections duplicates#122EclipseKnight wants to merge 2 commits intolostb1t:mainfrom
EclipseKnight wants to merge 2 commits intolostb1t:mainfrom
Conversation
Owner
|
Do you know which queries, how they look like? so we can understand what exactly causes the slowdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m combining this into one PR so it’s easier to review.
I traced the main issue to the filter guard in
GelatoItemRepository.ApplyFilters(after theIsSingleItemList()change around1cb8d57).IsSingleItemList()depends onidsin the HTTP query, but some internal query paths don’t passids, so those requests were getting filtered in places they shouldn’t. That caused slow loading/timeouts.I changed the guard to:
ctx.IsApiListing()filter.ItemIds is { Length: 1 }I also added
GetSectionContenttoBaseItemListActionNamesinCommon.cs.Reason for that:
HomeScreenController.GetSectionContentExcludeTags = [GelatoManager.StreamTag]applies and the duplicate stream variants are filtered out in those rowsI’m using this PR as the single place for both fixes.