Skip to content

Fix listing filter scope + Home Screen Sections duplicates#122

Open
EclipseKnight wants to merge 2 commits intolostb1t:mainfrom
EclipseKnight:fix/homescreen-listing-action-light
Open

Fix listing filter scope + Home Screen Sections duplicates#122
EclipseKnight wants to merge 2 commits intolostb1t:mainfrom
EclipseKnight:fix/homescreen-listing-action-light

Conversation

@EclipseKnight
Copy link

@EclipseKnight EclipseKnight commented Mar 1, 2026

I’m combining this into one PR so it’s easier to review.

I traced the main issue to the filter guard in GelatoItemRepository.ApplyFilters (after the IsSingleItemList() change around 1cb8d57).

IsSingleItemList() depends on ids in the HTTP query, but some internal query paths don’t pass ids, so those requests were getting filtered in places they shouldn’t. That caused slow loading/timeouts.

I changed the guard to:

  • use ctx.IsApiListing()
  • skip true single-item internal queries with filter.ItemIds is { Length: 1 }

I also added GetSectionContent to BaseItemListActionNames in Common.cs.

Reason for that:

  • Home Screen Sections latest rows come through HomeScreenController.GetSectionContent
  • if that action isn’t treated as listing, Gelato’s normal listing filter path doesn’t run there
  • once it is treated as listing, existing ExcludeTags = [GelatoManager.StreamTag] applies and the duplicate stream variants are filtered out in those rows

I’m using this PR as the single place for both fixes.

@EclipseKnight EclipseKnight changed the title Treat Home Screen section action as API listing Fix listing filter scope + Home Screen Sections duplicates Mar 1, 2026
@lostb1t
Copy link
Owner

lostb1t commented Mar 1, 2026

Do you know which queries, how they look like? so we can understand what exactly causes the slowdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants