+double WWW-Authenticate response header. Resolve Issue #949#1774
Open
chidozieononiwu wants to merge 1 commit intomicrosoft:mainfrom
Open
+double WWW-Authenticate response header. Resolve Issue #949#1774chidozieononiwu wants to merge 1 commit intomicrosoft:mainfrom
chidozieononiwu wants to merge 1 commit intomicrosoft:mainfrom
Conversation
chidozieononiwu
requested review from
JasonYeMSFT,
KarishmaGhiya,
hallipr,
jongio,
saikoumudi,
sandeep-sen and
tmeschter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where duplicate WWW-Authenticate response headers were being sent in authentication challenge responses for remote MCP servers. The issue occurred because the OnChallenge event handler was setting a custom WWW-Authenticate header but not preventing the default JWT Bearer handler from adding its own header.
Changes:
- Added
context.HandleResponse()call to prevent the default JWT Bearer handler from adding a second WWW-Authenticate header - Explicitly set the HTTP 401 status code before constructing the header
- Enhanced the WWW-Authenticate header construction to include error and error_description parameters when available
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs
Outdated
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
bugFix/AuthHeader
branch
from
2f0b8ea to
f034b7d
Compare
joshfree
reviewed
Feb 20, 2026
|
|
||
| context.Response.StatusCode = 401; | ||
|
|
||
| var header = $"Bearer realm=\"{request.Host}\", resource_metadata=\"{resourceMetadataUrl}\""; |
| context.Response.StatusCode = 401; | ||
|
|
||
| var header = $"Bearer realm=\"{request.Host}\", resource_metadata=\"{resourceMetadataUrl}\""; | ||
| if (!string.IsNullOrEmpty(context.Error)) |
chidozieononiwu
force-pushed
the
bugFix/AuthHeader
branch
from
f034b7d to
f9eeb0f
Compare
chidozieononiwu
force-pushed
the
bugFix/AuthHeader
branch
from
f9eeb0f to
65942bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove duplicate WWW-Authenticate
GitHub issue number?
#949